Bug 84274 - Win8 builds usually fail due to cygwin rebasing
Summary: Win8 builds usually fail due to cygwin rebasing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Justin Schuh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-18 13:58 PDT by Justin Schuh
Modified: 2012-04-18 15:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2012-04-18 14:34 PDT, Justin Schuh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Schuh 2012-04-18 13:58:24 PDT
Windows 8 has gotten much more aggressive about rebasing DLLs, so forking child processes fails (generally at least once per build attempt). Since we spawn lots of child processes, this usually causes builds to fail.
Comment 1 Justin Schuh 2012-04-18 14:34:36 PDT
Created attachment 137771 [details]
Patch
Comment 2 Justin Schuh 2012-04-18 14:36:06 PDT
This patch is a bit of a hack, but it doesn't seem overly egregious to simply make compiling on win8 work. And anything more significant would be extremely invasive.
Comment 3 Dirk Pranke 2012-04-18 14:42:53 PDT
Comment on attachment 137771 [details]
Patch

ugh. I look forward to getting rid of cygwin ...
Comment 4 Justin Schuh 2012-04-18 14:44:52 PDT
So do I, and thanks.
Comment 5 WebKit Review Bot 2012-04-18 15:29:19 PDT
Comment on attachment 137771 [details]
Patch

Clearing flags on attachment: 137771

Committed r114569: <http://trac.webkit.org/changeset/114569>
Comment 6 WebKit Review Bot 2012-04-18 15:29:24 PDT
All reviewed patches have been landed.  Closing bug.