Bug 84273 - [V8] Pass Isolate to toV8() (Part6)
Summary: [V8] Pass Isolate to toV8() (Part6)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 84074
  Show dependency treegraph
Reported: 2012-04-18 13:45 PDT by Kentaro Hara
Modified: 2012-04-23 17:56 PDT (History)
3 users (show)

See Also:

Patch (19.46 KB, patch)
2012-04-18 13:51 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (23.40 KB, patch)
2012-04-18 13:57 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (26.40 KB, patch)
2012-04-18 14:00 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (21.48 KB, patch)
2012-04-23 12:59 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-18 13:45:32 PDT
The objective is to pass Isolate to all toV8()s. Since there are a lot of toV8()s, I'll make the change step by step. In this bug, we pass Isolate to toV8() in several custom bindings.

I think this will continue to Part7 or so.
Comment 1 Kentaro Hara 2012-04-18 13:51:19 PDT
Created attachment 137760 [details]
Comment 2 Kentaro Hara 2012-04-18 13:57:22 PDT
Created attachment 137761 [details]
Comment 3 Kentaro Hara 2012-04-18 14:00:39 PDT
Created attachment 137762 [details]
Comment 4 WebKit Review Bot 2012-04-23 11:49:13 PDT
Comment on attachment 137762 [details]

Rejecting attachment 137762 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
patching file Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Nate Chapin']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12472836
Comment 5 Kentaro Hara 2012-04-23 12:59:29 PDT
Created attachment 138404 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-04-23 17:55:14 PDT
Comment on attachment 138404 [details]
patch for landing

Clearing flags on attachment: 138404

Committed r114972: <http://trac.webkit.org/changeset/114972>