WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84257
[V8][Refactoring] Remove V8Proxy::toV8()
https://bugs.webkit.org/show_bug.cgi?id=84257
Summary
[V8][Refactoring] Remove V8Proxy::toV8()
Kentaro Hara
Reported
2012-04-18 11:05:32 PDT
Some constructorCallback()s are using V8Proxy::toV8(), other constructorCallback()s are directly using setJSWrapperForXXX() (XXX can be DOMObject, ActiveDOMObject, Node or ActiveNode). We should unify them. Considering the fact that V8Proxy::toV8() just supports XXX=DOMObject and thus is not flexible, replacing V8Proxy::toV8() with setJSWrapperForXXX() would make sense.
Attachments
Patch
(11.26 KB, patch)
2012-04-18 11:10 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-04-18 11:10:11 PDT
Created
attachment 137726
[details]
Patch
WebKit Review Bot
Comment 2
2012-04-23 11:33:19 PDT
Comment on
attachment 137726
[details]
Patch Clearing flags on attachment: 137726 Committed
r114922
: <
http://trac.webkit.org/changeset/114922
>
WebKit Review Bot
Comment 3
2012-04-23 11:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug