Bug 84257 - [V8][Refactoring] Remove V8Proxy::toV8()
Summary: [V8][Refactoring] Remove V8Proxy::toV8()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 84074
  Show dependency treegraph
Reported: 2012-04-18 11:05 PDT by Kentaro Hara
Modified: 2012-04-23 11:33 PDT (History)
3 users (show)

See Also:

Patch (11.26 KB, patch)
2012-04-18 11:10 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-18 11:05:32 PDT
Some constructorCallback()s are using V8Proxy::toV8(), other constructorCallback()s are directly using setJSWrapperForXXX() (XXX can be DOMObject, ActiveDOMObject, Node or ActiveNode). We should unify them.

Considering the fact that V8Proxy::toV8() just supports XXX=DOMObject and thus is not flexible, replacing V8Proxy::toV8() with setJSWrapperForXXX() would make sense.
Comment 1 Kentaro Hara 2012-04-18 11:10:11 PDT
Created attachment 137726 [details]
Comment 2 WebKit Review Bot 2012-04-23 11:33:19 PDT
Comment on attachment 137726 [details]

Clearing flags on attachment: 137726

Committed r114922: <http://trac.webkit.org/changeset/114922>
Comment 3 WebKit Review Bot 2012-04-23 11:33:24 PDT
All reviewed patches have been landed.  Closing bug.