Bug 84243 - Clean-up WheelEvent Conversion
Summary: Clean-up WheelEvent Conversion
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on:
Blocks: 75006
  Show dependency treegraph
Reported: 2012-04-18 08:04 PDT by Allan Sandfeld Jensen
Modified: 2012-04-18 12:48 PDT (History)
3 users (show)

See Also:

Patch (12.87 KB, patch)
2012-04-18 08:14 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-04-18 08:04:22 PDT
WheelEvent conversion is currently doesnt treat full ticks and partial ticks the same way. This appears to have been done to support wheel-events emitted by DRT. This should be cleaned up so all wheel-events are treated the same, and DRT emits correct events.

The problem is in particular to distinguish better between wheel-delta and pixel-delta which are often confused, and happens to be identical on some other platforms.
Comment 1 Allan Sandfeld Jensen 2012-04-18 08:14:41 PDT
Created attachment 137692 [details]
Comment 2 Simon Hausmann 2012-04-18 11:45:16 PDT
Comment on attachment 137692 [details]

r=me. Nice cleanup!

There have been some cleanups in QWheelEvent lately, too, FWIW: http://qt.gitorious.org/qt/qtbase/commit/5a2efb490bc3549ef42420a0dafcf22072785e0d
Comment 3 WebKit Review Bot 2012-04-18 12:48:51 PDT
Comment on attachment 137692 [details]

Clearing flags on attachment: 137692

Committed r114546: <http://trac.webkit.org/changeset/114546>
Comment 4 WebKit Review Bot 2012-04-18 12:48:56 PDT
All reviewed patches have been landed.  Closing bug.