RESOLVED FIXED 84241
[Qt][WK2] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions() 
https://bugs.webkit.org/show_bug.cgi?id=84241
Summary [Qt][WK2] Remove redundant updateViewportArguments() call from HTMLBodyElemen...
zalan
Reported 2012-04-18 07:57:38 PDT
SSIA
Attachments
Patch (6.27 KB, patch)
2012-04-18 09:39 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.40 KB, patch)
2012-04-19 23:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.25 KB, patch)
2012-05-02 04:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2012-05-02 05:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2012-04-18 09:39:59 PDT
Created attachment 137709 [details] Patch
zalan
Comment 2 2012-04-18 09:41:23 PDT
this patch also checks (asserts) that at least one viewport arguments update is dispatched per main frame.
Kenneth Rohde Christiansen
Comment 3 2012-04-19 16:13:05 PDT
Comment on attachment 137709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137709&action=review > Source/WebCore/ChangeLog:3 > + Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions() inseretions? > Source/WebCore/dom/Document.cpp:481 > + , m_didDispatchViewportPropertiesChanged(false) This is for debugging only so why not use NDEBUG?
zalan
Comment 4 2012-04-19 21:49:06 PDT
(In reply to comment #3) > (From update of attachment 137709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137709&action=review > > > Source/WebCore/ChangeLog:3 > > + Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions() > > inseretions? Yea, that's what it's called. > > > Source/WebCore/dom/Document.cpp:481 > > + , m_didDispatchViewportPropertiesChanged(false) > > This is for debugging only so why not use NDEBUG? bad habit. surely can do that.
zalan
Comment 5 2012-04-19 23:12:21 PDT
Created attachment 138048 [details] Patch
zalan
Comment 6 2012-05-02 04:41:43 PDT
Created attachment 139787 [details] Patch
WebKit Review Bot
Comment 7 2012-05-02 05:02:26 PDT
Comment on attachment 139787 [details] Patch Rejecting attachment 139787 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Kenneth Christiansen found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12581951
zalan
Comment 8 2012-05-02 05:13:55 PDT
Created attachment 139791 [details] Patch
WebKit Review Bot
Comment 9 2012-05-02 06:00:03 PDT
Comment on attachment 139791 [details] Patch Clearing flags on attachment: 139791 Committed r115819: <http://trac.webkit.org/changeset/115819>
WebKit Review Bot
Comment 10 2012-05-02 06:00:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.