SSIA
Created attachment 137709 [details] Patch
this patch also checks (asserts) that at least one viewport arguments update is dispatched per main frame.
Comment on attachment 137709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137709&action=review > Source/WebCore/ChangeLog:3 > + Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions() inseretions? > Source/WebCore/dom/Document.cpp:481 > + , m_didDispatchViewportPropertiesChanged(false) This is for debugging only so why not use NDEBUG?
(In reply to comment #3) > (From update of attachment 137709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137709&action=review > > > Source/WebCore/ChangeLog:3 > > + Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions() > > inseretions? Yea, that's what it's called. > > > Source/WebCore/dom/Document.cpp:481 > > + , m_didDispatchViewportPropertiesChanged(false) > > This is for debugging only so why not use NDEBUG? bad habit. surely can do that.
Created attachment 138048 [details] Patch
Created attachment 139787 [details] Patch
Comment on attachment 139787 [details] Patch Rejecting attachment 139787 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Kenneth Christiansen found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12581951
Created attachment 139791 [details] Patch
Comment on attachment 139791 [details] Patch Clearing flags on attachment: 139791 Committed r115819: <http://trac.webkit.org/changeset/115819>
All reviewed patches have been landed. Closing bug.