Bug 84240 - Web Inspector: DataGrid should use explicit root node
Summary: Web Inspector: DataGrid should use explicit root node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-18 07:29 PDT by Yury Semikhatsky
Modified: 2012-04-18 08:00 PDT (History)
11 users (show)

See Also:

Attachments
Patch (49.64 KB, patch)
2012-04-18 07:49 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-04-18 07:29:27 PDT 
Instead of pretending to be a regular node DataGrid object should have an explicit root node that would contain all its children. This way we don't need to share some methods between DataGridNode and DataGrid.
Comment 1 Yury Semikhatsky 2012-04-18 07:49:11 PDT 
Created attachment 137686 [details]
Patch
Comment 2 Pavel Feldman 2012-04-18 07:54:05 PDT 
Comment on attachment 137686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review

> Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208
> +        this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode());

You should create root node implicitly within the data grid.
Comment 3 Yury Semikhatsky 2012-04-18 07:57:37 PDT 
(In reply to comment #2)
> (From update of attachment 137686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review
> 
> > Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208
> > +        this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode());
> 
> You should create root node implicitly within the data grid.

Done.
Comment 4 Yury Semikhatsky 2012-04-18 08:00:13 PDT 
Committed r114504: <http://trac.webkit.org/changeset/114504>