RESOLVED FIXED 84240
Web Inspector: DataGrid should use explicit root node 
https://bugs.webkit.org/show_bug.cgi?id=84240
Summary Web Inspector: DataGrid should use explicit root node
Yury Semikhatsky
Reported 2012-04-18 07:29:27 PDT
Instead of pretending to be a regular node DataGrid object should have an explicit root node that would contain all its children. This way we don't need to share some methods between DataGridNode and DataGrid.
Attachments
Patch (49.64 KB, patch)
2012-04-18 07:49 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-04-18 07:49:11 PDT
Created attachment 137686 [details] Patch
Pavel Feldman
Comment 2 2012-04-18 07:54:05 PDT
Comment on attachment 137686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review > Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208 > + this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode()); You should create root node implicitly within the data grid.
Yury Semikhatsky
Comment 3 2012-04-18 07:57:37 PDT
(In reply to comment #2) > (From update of attachment 137686 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review > > > Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208 > > + this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode()); > > You should create root node implicitly within the data grid. Done.
Yury Semikhatsky
Comment 4 2012-04-18 08:00:13 PDT
Committed r114504: <http://trac.webkit.org/changeset/114504>
Note You need to log in before you can comment on or make changes to this bug.