WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84236
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236
Summary
[EFL] DRT console messages should contain only the file name part of local URIs
Chris Dumez
Reported
2012-04-18 05:35:23 PDT
Several test cases are failing because they expect DRT console message to contain only the file name part of local URIs. I identified the following test cases which are failing because of this issue: fast/frames/sandboxed-iframe-close-top-noclose.html fast/frames/sandboxed-iframe-history-denied.html fast/frames/sandboxed-iframe-navigation-parent.html fast/frames/sandboxed-iframe-navigation-targetlink.html fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html fast/frames/sandboxed-iframe-navigation-top-denied.html Their failure diff looks like: --- /home/buildslave-1/webkit-buildslave/efl-linux-debug/build/layout-test-results/fast/frames/sandboxed-iframe-close-top-noclose-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-debug/build/layout-test-results/fast/frames/sandboxed-iframe-close-top-noclose-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL close-top.html. +CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL file:///home/buildslave-1/webkit-buildslave/efl-linux-debug/build/LayoutTests/fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html from frame with URL file:///home/buildslave-1/webkit-buildslave/efl-linux-debug/build/LayoutTests/fast/frames/resources/close-top.html.
Attachments
Patch
(2.36 KB, patch)
2012-04-18 05:42 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(4.30 KB, patch)
2012-04-18 22:52 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-04-18 05:42:55 PDT
Created
attachment 137675
[details]
Patch
Raphael Kubo da Costa (:rakuco)
Comment 2
2012-04-18 08:06:16 PDT
Comment on
attachment 137675
[details]
Patch The patch looks fine. Don't you need to unskip some tests related to this?
Chris Dumez
Comment 3
2012-04-18 09:54:12 PDT
No, those are broken tests which are not part of the skip list.
Raphael Kubo da Costa (:rakuco)
Comment 4
2012-04-18 10:00:52 PDT
Hmm, I was talking about the section around line 1654 in the skipped list that says "BUG: The whole file path is being shown in the console message instead of only the file name".
Chris Dumez
Comment 5
2012-04-18 11:33:58 PDT
Oh sorry, I missed those. I'll make sure they pass and unskip if necessary. Thanks.
Chris Dumez
Comment 6
2012-04-18 22:52:51 PDT
Created
attachment 137843
[details]
Patch Unskip the tests which now pass because of this fix.
Raphael Kubo da Costa (:rakuco)
Comment 7
2012-04-19 08:02:47 PDT
Comment on
attachment 137843
[details]
Patch Looks OK, thanks.
Kentaro Hara
Comment 8
2012-04-19 16:10:09 PDT
Comment on
attachment 137843
[details]
Patch OK
WebKit Review Bot
Comment 9
2012-04-19 16:50:55 PDT
Comment on
attachment 137843
[details]
Patch Clearing flags on attachment: 137843 Committed
r114694
: <
http://trac.webkit.org/changeset/114694
>
WebKit Review Bot
Comment 10
2012-04-19 16:51:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug