Bug 84229 – [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dominik Röttsches (drott)]

Build 203 [1] on the debug and build 35578 on the release buildbot included important changes from bug 84052 and bug 83281. However, they did not trigger rebuilds of the required objects, leading to an increase in failure rates by about 140 cases. So, from svn revision 114416 to 114420, the buildsystem failed to trigger the appropriate rebuild. This needs to be fixed urgently.

[1] http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/203
[2] http://build.webkit.org/builders/EFL%20Linux%20Release/builds/35578

[Dominik Röttsches (drott)]

--cmakearg="-DCMAKE_VERBOSE_MAKEFILE=ON" as an argument to build-webkit --efl might be helpful.

[Sudarsana Nagineni (babu)]

Looks like EFl buildbots are triggering rebuilds of changes only when we force a clean build.

[Sudarsana Nagineni (babu)]

The root cause of this issue is ONLY_BUILD_JAVASCRIPTCORE is always ON after running run-javascriptcore-tests(value is stored in CMakeCache.txt) and the following check in CMakeLists.txt ignores building other modules when this option is ON.

OPTION(ONLY_BUILD_JAVASCRIPTCORE "only build JavaScriptCore")
IF (ONLY_BUILD_JAVASCRIPTCORE)
    SET(ENABLE_WEBCORE OFF)
    SET(ENABLE_WEBKIT OFF)
    SET(ENABLE_WEBKIT2 OFF)
    SET(ENABLE_TOOLS OFF)
ENDIF ()

To fix the issue we should set this option OFF when we run build-webkit.

[Thiago Marcos P. Santos]

Created attachment 137674 [details]
Patch fixing buildsystem.

[Thiago Marcos P. Santos]

Created attachment 137677 [details]
Same patch, better changelog.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 137677 [details]
Same patch, better changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review

> Tools/Scripts/build-jsc:73
> +    buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened

As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess.

[Rob Buis]

Comment on attachment 137677 [details]
Same patch, better changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review

>> Tools/Scripts/build-jsc:73
>> +    buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened
> 
> As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess.

Why not use JSC_EXECUTABLE_NAME in the first place instead of hardcoding jsc?

[Rob Buis]

Comment on attachment 137677 [details]
Same patch, better changelog.

Looks good.

[WebKit Review Bot]

Comment on attachment 137677 [details]
Same patch, better changelog.

Clearing flags on attachment: 137677

Committed r114508: <http://trac.webkit.org/changeset/114508>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.