Bug 84228 – Clean up gain properties from AudioBuffer and AudioBufferSourceNode

• Status: UNCONFIRMED
• Component: Web Audio

[Xingnan Wang]

Because they are removed from the latest spec.

[Xingnan Wang]

Created attachment 137656 [details]
Patch

[Chris Rogers]

This generally looks good, but I tested the patch and it breaks a few pages I've tested so far.  Maybe we should "deprecate" this API first (with console warning) so we have a chance to warn developers a bit ahead of time.  It's not actually critical that we remove this API, since it's more of a general cleanup than a trouble-making API.

[Eric Seidel (no email)]

Comment on attachment 137656 [details]
Patch

I'm all for removing code.

[Eric Seidel (no email)]

Comment on attachment 137656 [details]
Patch

Chris, do you have a specific deprecation plan?

[Chris Rogers]

(In reply to comment #4)
> (From update of attachment 137656 [details])
> Chris, do you have a specific deprecation plan?

Although these attributes are removed in the spec, I was considering delaying pulling out support (for now) and outputting console warnings about "deprecated API" to give people a chance to fix their code

[Eric Seidel (no email)]

Attachment 137656 [details] was posted by a committer and has review+, assigning to Xingnan Wang for commit.

[WebKit Review Bot]

Comment on attachment 137656 [details]
Patch

Rejecting attachment 137656 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
k #3 FAILED at 150.
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h.rej
patching file Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl
Hunk #1 FAILED at 38.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15703085

[Chris Rogers]

Comment on attachment 137656 [details]
Patch

Please delay landing until we can determine how much breakage this will cause in existing pages.