Bug 84215 - [Chromium] Solid color shader should use premultiplied alpha.
Summary: [Chromium] Solid color shader should use premultiplied alpha.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks: 84197
  Show dependency treegraph
 
Reported: 2012-04-17 17:14 PDT by David Reveman
Modified: 2012-04-18 13:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.56 KB, patch)
2012-04-17 17:48 PDT, David Reveman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2012-04-17 17:14:22 PDT
This is mostly for consistency. Textures are expected to have premultiplied alpha so I don't think there's a good reason not to expect that in the solid color shader as well. Also faster not to compute the color per-pixel even though I doubt that matters.
Comment 1 David Reveman 2012-04-17 17:48:22 PDT
Created attachment 137642 [details]
Patch
Comment 2 Antoine Labour 2012-04-17 17:52:01 PDT
LGTM
Comment 3 Adrienne Walker 2012-04-18 11:23:42 PDT
Comment on attachment 137642 [details]
Patch

Sounds good.  R=me.
Comment 4 WebKit Review Bot 2012-04-18 13:35:00 PDT
Comment on attachment 137642 [details]
Patch

Clearing flags on attachment: 137642

Committed r114552: <http://trac.webkit.org/changeset/114552>
Comment 5 WebKit Review Bot 2012-04-18 13:35:04 PDT
All reviewed patches have been landed.  Closing bug.