We're getting near the end of what can be landed in trunk without switching to FractionalLayoutUnits. This patch is made up of a bunch of small changes in different files that slipped through the cracks before.
Created attachment 137636 [details] Patch
Comment on attachment 137636 [details] Patch OK.
Comment on attachment 137636 [details] Patch Rejecting attachment 137636 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/12418921
(In reply to comment #3) > (From update of attachment 137636 [details]) > Rejecting attachment 137636 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 > > Last 500 characters of output: > ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors > self._run(tool, options, state) > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run > step(tool, options).run(state) > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run > if changelog_entry.has_valid_reviewer(): > AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' > > Full output: http://queues.webkit.org/results/12418921 Any idea what this error is about?
Likely failed to parse the ChangeLog.
Comment on attachment 137636 [details] Patch Clearing flags on attachment: 137636 Committed r114470: <http://trac.webkit.org/changeset/114470>
All reviewed patches have been landed. Closing bug.