Bug 84209 - Clean up outstanding LayoutUnit misuse in WebCore
Summary: Clean up outstanding LayoutUnit misuse in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-17 16:33 PDT by Levi Weintraub
Modified: 2012-04-17 17:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.06 KB, patch)
2012-04-17 16:45 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-17 16:33:06 PDT 
We're getting near the end of what can be landed in trunk without switching to FractionalLayoutUnits. This patch is made up of a bunch of small changes in different files that slipped through the cracks before.
Comment 1 Levi Weintraub 2012-04-17 16:45:45 PDT 
Created attachment 137636 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-17 16:57:05 PDT 
Comment on attachment 137636 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2012-04-17 17:00:07 PDT 
Comment on attachment 137636 [details]
Patch

Rejecting attachment 137636 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/12418921
Comment 4 Levi Weintraub 2012-04-17 17:05:01 PDT 
(In reply to comment #3)
> (From update of attachment 137636 [details])
> Rejecting attachment 137636 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> Last 500 characters of output:
> ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
>     self._run(tool, options, state)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
>     step(tool, options).run(state)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
>     if changelog_entry.has_valid_reviewer():
> AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'
> 
> Full output: http://queues.webkit.org/results/12418921

Any idea what this error is about?
Comment 5 Eric Seidel (no email) 2012-04-17 17:14:44 PDT 
Likely failed to parse the ChangeLog.
Comment 6 Levi Weintraub 2012-04-17 17:30:08 PDT 
Comment on attachment 137636 [details]
Patch

Clearing flags on attachment: 137636

Committed r114470: <http://trac.webkit.org/changeset/114470>
Comment 7 Levi Weintraub 2012-04-17 17:30:11 PDT 
All reviewed patches have been landed.  Closing bug.