Bug 84200 – It should be possible to create an inheritorID for the global this object without crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

The global this object has a structure that has a null global object. That makes sense since there is no one global object that the structure could be associated with. But what doesn't make sense is that this leads to the inheritorID structure created for objects that have the global this object as their prototype also having a null global object, which then results in hilarity and badness when any operation is performed on those objects that expects to be able to query the global object via the structure.

[Filip Pizlo]

<rdar://problem/11251082>

[Filip Pizlo]

Created attachment 137615 [details]
the patch

[Filip Pizlo]

Created attachment 137616 [details]
the patch

[WebKit Review Bot]

Attachment 137616 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSGlobalThis.h:68:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSGlobalThis.h:68:  The parameter name "globalObject" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 137616 [details]
the patch

Attachment 137616 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12415987

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/114457

[Filip Pizlo]

Windows build fix: http://trac.webkit.org/changeset/114459