Bug 84200 - It should be possible to create an inheritorID for the global this object without crashing
Summary: It should be possible to create an inheritorID for the global this object wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-17 15:06 PDT by Filip Pizlo
Modified: 2012-04-17 16:04 PDT (History)
1 user (show)

See Also:

Attachments
the patch (6.21 KB, patch)
2012-04-17 15:08 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (5.81 KB, patch)
2012-04-17 15:10 PDT, Filip Pizlo 		oliver: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-04-17 15:06:27 PDT 
The global this object has a structure that has a null global object. That makes sense since there is no one global object that the structure could be associated with. But what doesn't make sense is that this leads to the inheritorID structure created for objects that have the global this object as their prototype also having a null global object, which then results in hilarity and badness when any operation is performed on those objects that expects to be able to query the global object via the structure.
Comment 1 Filip Pizlo 2012-04-17 15:06:35 PDT 
<rdar://problem/11251082>
Comment 2 Filip Pizlo 2012-04-17 15:08:15 PDT 
Created attachment 137615 [details]
the patch
Comment 3 Filip Pizlo 2012-04-17 15:10:52 PDT 
Created attachment 137616 [details]
the patch
Comment 4 WebKit Review Bot 2012-04-17 15:14:23 PDT 
Attachment 137616 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSGlobalThis.h:68:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSGlobalThis.h:68:  The parameter name "globalObject" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2012-04-17 15:43:02 PDT 
Comment on attachment 137616 [details]
the patch

Attachment 137616 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12415987
Comment 6 Filip Pizlo 2012-04-17 16:02:11 PDT 
Landed in http://trac.webkit.org/changeset/114457
Comment 7 Filip Pizlo 2012-04-17 16:04:06 PDT 
Windows build fix: http://trac.webkit.org/changeset/114459