Bug 84194 - REGRESSION(r112155): Children style not always recalculated in CSS animations
Summary: REGRESSION(r112155): Children style not always recalculated in CSS animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
: 84371 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-04-17 14:34 PDT by Loïc Yhuel
Modified: 2012-06-07 21:38 PDT (History)
5 users (show)

See Also:


Attachments
blinking text animation (423 bytes, text/html)
2012-04-17 14:34 PDT, Loïc Yhuel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Yhuel 2012-04-17 14:34:45 PDT
Created attachment 137607 [details]
blinking text animation

The attached blink animation no longer works since https://bugs.webkit.org/show_bug.cgi?id=79389 has landed.

There are paints, but the text is always black.

In Element::recalcStyle, when the text color should be changed to white :
 - styleChangeType() is SyntheticStyleChange, the animated style (color: white) is set on the Element in setRenderStyle(newStyle)
 - currentStyle and newStyle are the same (color: black), so ch is NoChange
 - After r112155, change is no more set to Force, so Text::recalcTextStyle is called with NoChange as argument, the style of the text is not changed, so the text color remains black.
Comment 1 Alexey Proskuryakov 2012-04-17 14:49:08 PDT
<rdar://problem/11267408>
Comment 2 Alexey Proskuryakov 2012-05-22 10:55:51 PDT
Rob, would you be willing to investigate this regression?
Comment 3 Rob Arnold 2012-05-22 18:32:53 PDT
Yes, I should have investigated sooner. Unfortunately it'll probably be 2 weeks before I can really dig into this (vacation + needing to unblock a bunch of people at FB). It looks like Loïc did some nice investigation; my current plan is to see if forcing recalcuation when the new style has inheritable properties (ideally if they changed / are used) will work.
Comment 4 Dean Jackson 2012-05-25 12:34:37 PDT
We're getting multiple reports of this breaking various things. I'm going to revert the change from https://bugs.webkit.org/show_bug.cgi?id=79389
Comment 5 Dean Jackson 2012-05-25 13:03:48 PDT
Reverted in http://trac.webkit.org/changeset/118553
Comment 6 Dean Jackson 2012-05-25 13:08:41 PDT
Reverting fixed the attached testcase.
Comment 7 Marc Hoyois 2012-06-07 21:38:51 PDT
*** Bug 84371 has been marked as a duplicate of this bug. ***