Bug 84194 – REGRESSION(r112155): Children style not always recalculated in CSS animations

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Loïc Yhuel]

Created attachment 137607 [details]
blinking text animation

The attached blink animation no longer works since https://bugs.webkit.org/show_bug.cgi?id=79389 has landed.

There are paints, but the text is always black.

In Element::recalcStyle, when the text color should be changed to white :
 - styleChangeType() is SyntheticStyleChange, the animated style (color: white) is set on the Element in setRenderStyle(newStyle)
 - currentStyle and newStyle are the same (color: black), so ch is NoChange
 - After r112155, change is no more set to Force, so Text::recalcTextStyle is called with NoChange as argument, the style of the text is not changed, so the text color remains black.

[Alexey Proskuryakov]

<rdar://problem/11267408>

[Alexey Proskuryakov]

Rob, would you be willing to investigate this regression?

[Rob Arnold]

Yes, I should have investigated sooner. Unfortunately it'll probably be 2 weeks before I can really dig into this (vacation + needing to unblock a bunch of people at FB). It looks like Loïc did some nice investigation; my current plan is to see if forcing recalcuation when the new style has inheritable properties (ideally if they changed / are used) will work.

[Dean Jackson]

We're getting multiple reports of this breaking various things. I'm going to revert the change from https://bugs.webkit.org/show_bug.cgi?id=79389

[Dean Jackson]

Reverted in http://trac.webkit.org/changeset/118553

[Dean Jackson]

Reverting fixed the attached testcase.

[Marc Hoyois]

*** Bug 84371 has been marked as a duplicate of this bug. ***