RESOLVED FIXED Bug 84191
GraphicsContextCG's roundToDevicePixels should round even when there's no transform 
https://bugs.webkit.org/show_bug.cgi?id=84191
Summary GraphicsContextCG's roundToDevicePixels should round even when there's no tra...
Levi Weintraub
Reported 2012-04-17 13:54:10 PDT
Currently, if there's no transform on the graphics context, the CG implementation of GraphicsContext::roundToDevicePixels returns the rect passed in instead of rounding. This breaks text underlines when sub-pixel layout is enabled.
Attachments
Patch (2.61 KB, patch)
2012-04-17 14:20 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (3.49 KB, patch)
2012-04-18 11:15 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-17 14:20:30 PDT
Created attachment 137601 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-17 17:04:33 PDT
Comment on attachment 137601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137601&action=review Wouldn't rect.round() do the same thing? Or do we call it roundedIntRect(rect)? In either case, I would be surprised if the float -> int -> float conversion would matter, and would save adding a couple lines of code. > Source/WebCore/ChangeLog:11 > + end up being more than on3e pixel wide. This adds a static inline rounding method and uses it for on3e
Levi Weintraub
Comment 3 2012-04-18 11:15:28 PDT
Created attachment 137728 [details] Patch
Eric Seidel (no email)
Comment 4 2012-04-18 11:54:33 PDT
Comment on attachment 137728 [details] Patch LGTM.
Levi Weintraub
Comment 5 2012-04-18 11:55:53 PDT
Comment on attachment 137728 [details] Patch Thanks Eric :)
WebKit Review Bot
Comment 6 2012-04-18 13:05:27 PDT
Comment on attachment 137728 [details] Patch Clearing flags on attachment: 137728 Committed r114548: <http://trac.webkit.org/changeset/114548>
WebKit Review Bot
Comment 7 2012-04-18 13:05:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.