Bug 84190 - nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
: nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromi...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Dirk Pranke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-17 13:49 PDT by Dirk Pranke
Modified: 2012-04-17 15:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-04-17 13:50 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-04-17 13:49:43 PDT
nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
Comment 1 Dirk Pranke 2012-04-17 13:50:03 PDT
Created attachment 137598 [details]
Patch
Comment 2 Ojan Vafai 2012-04-17 14:25:41 PDT
Comment on attachment 137598 [details]
Patch

Would be nice if the changelog had a description of when you'd get an IOError.
Comment 3 Dirk Pranke 2012-04-17 14:28:20 PDT
(In reply to comment #2)
> (From update of attachment 137598 [details])
> Would be nice if the changelog had a description of when you'd get an IOError.

Oh, you get the IOError when the layout test helper has exited early (due to the ctrl-c) and we try to write to it. I will make that clearer.
Comment 4 Dirk Pranke 2012-04-17 15:09:42 PDT
Committed r114442: <http://trac.webkit.org/changeset/114442>