Bug 84175 – Change RenderThemeChromiumSkia paint methods to use pixel snapping

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Change RenderThemeChromiumSkia paint methods to use pixel snapping in preparation for turning on subpixel layout.

[Emil A Eklund]

Created attachment 137578 [details]
Patch

[WebKit Review Bot]

Comment on attachment 137578 [details]
Patch

Attachment 137578 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12425092

[Emil A Eklund]

Created attachment 137630 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 137630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286
> +    LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height()));

Don't we normally have "using namespace std;" at the top of cpp files which need min/max?

[Emil A Eklund]

Comment on attachment 137630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review

>> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286
>> +    LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height()));
> 
> Don't we normally have "using namespace std;" at the top of cpp files which need min/max?

Normally we do, I wanted to be consistent with the rest of the file though. If you'd like I could change all of it.

[Eric Seidel (no email)]

Yeah, I noticed that after I made the comment, so I just set cq+.  It's fine. :)

[WebKit Review Bot]

Comment on attachment 137630 [details]
Patch

Clearing flags on attachment: 137630

Committed r114471: <http://trac.webkit.org/changeset/114471>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.