Change RenderThemeChromiumSkia paint methods to use pixel snapping in preparation for turning on subpixel layout.
Created attachment 137578 [details] Patch
Comment on attachment 137578 [details] Patch Attachment 137578 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12425092
Created attachment 137630 [details] Patch
Comment on attachment 137630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review > Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286 > + LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height())); Don't we normally have "using namespace std;" at the top of cpp files which need min/max?
Comment on attachment 137630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review >> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286 >> + LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height())); > > Don't we normally have "using namespace std;" at the top of cpp files which need min/max? Normally we do, I wanted to be consistent with the rest of the file though. If you'd like I could change all of it.
Yeah, I noticed that after I made the comment, so I just set cq+. It's fine. :)
Comment on attachment 137630 [details] Patch Clearing flags on attachment: 137630 Committed r114471: <http://trac.webkit.org/changeset/114471>
All reviewed patches have been landed. Closing bug.