Bug 84166 - Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
: Web Inspector: [Chromium] Module's require injects scripts before the debug i...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
:
Depends on: 84253
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-17 10:53 PDT by Pavel Feldman
Modified: 2012-04-18 11:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.74 KB, patch)
2012-04-17 11:01 PDT, Pavel Feldman
yurys: review+
webkit.review.bot: commit‑queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (5.92 MB, application/zip)
2012-04-17 11:58 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-17 10:53:32 PDT
V8IsolatedContext is getting debug id assigned post-construction. At the same time, it gets all helper module scripts injected within the constructor. As a result, scripts end up in the main world's list.
Comment 1 Pavel Feldman 2012-04-17 11:01:14 PDT
Created attachment 137562 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-17 11:58:22 PDT
Comment on attachment 137562 [details]
Patch

Attachment 137562 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12418777

New failing tests:
svg/transforms/text-with-pattern-with-svg-transform.svg
Comment 3 WebKit Review Bot 2012-04-17 11:58:28 PDT
Created attachment 137571 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Pavel Feldman 2012-04-18 03:10:11 PDT
Committed r114497: <http://trac.webkit.org/changeset/114497>
Comment 5 Pavel Feldman 2012-04-18 11:15:15 PDT
Committed r114535: <http://trac.webkit.org/changeset/114535>