Bug 84166 - Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
: Web Inspector: [Chromium] Module's require injects scripts before the debug i...
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
: 84253
:
  Show dependency treegraph
 
Reported: 2012-04-17 10:53 PST by
Modified: 2012-04-18 11:15 PST (History)


Attachments
Patch (5.74 KB, patch)
2012-04-17 11:01 PST, Pavel Feldman
yurys: review+
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (5.92 MB, application/zip)
2012-04-17 11:58 PST, WebKit Review Bot
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-17 10:53:32 PST
V8IsolatedContext is getting debug id assigned post-construction. At the same time, it gets all helper module scripts injected within the constructor. As a result, scripts end up in the main world's list.
------- Comment #1 From 2012-04-17 11:01:14 PST -------
Created an attachment (id=137562) [details]
Patch
------- Comment #2 From 2012-04-17 11:58:22 PST -------
(From update of attachment 137562 [details])
Attachment 137562 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12418777

New failing tests:
svg/transforms/text-with-pattern-with-svg-transform.svg
------- Comment #3 From 2012-04-17 11:58:28 PST -------
Created an attachment (id=137571) [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #4 From 2012-04-18 03:10:11 PST -------
Committed r114497: <http://trac.webkit.org/changeset/114497>
------- Comment #5 From 2012-04-18 11:15:15 PST -------
Committed r114535: <http://trac.webkit.org/changeset/114535>