Bug 84148 - Web Inspector: Suggest box appears after the command was executed in console sometimes.
Summary: Web Inspector: Suggest box appears after the command was executed in console ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 06:22 PDT by Vsevolod Vlasov
Modified: 2012-04-17 08:38 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2012-04-17 06:28 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-04-17 06:22:24 PDT
TextPrompt.complete() requests completions asynchronously, we should check that we still need completions in TextPrompt._completionsReady().
Comment 1 Vsevolod Vlasov 2012-04-17 06:28:34 PDT
Created attachment 137528 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-04-17 08:29:16 PDT
Comment on attachment 137528 [details]
Patch

Looks good to me
Comment 3 Vsevolod Vlasov 2012-04-17 08:38:59 PDT
Committed r114382: <http://trac.webkit.org/changeset/114382>