Bug 84143 - [GTK] Allow to use WebInspector in GtkLauncher
Summary: [GTK] Allow to use WebInspector in GtkLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-04-17 05:02 PDT by Carlos Garcia Campos
Modified: 2012-04-19 23:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.74 KB, patch)
2012-04-17 05:07 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-04-17 05:02:56 PDT 
It currently crashes when you click on Inspect element context menu item.
Comment 1 Carlos Garcia Campos 2012-04-17 05:07:02 PDT 
Created attachment 137517 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-17 05:10:40 PDT 
Attachment 137517 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/GNUmakefile.am',..." exit_code: 1
Tools/GtkLauncher/LauncherInspectorWindow.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:50:  launcher_inspector_window_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:56:  launcher_inspector_window_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.h:44:  launcher_inspector_window_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2012-04-19 16:12:12 PDT 
Comment on attachment 137517 [details]
Patch

Nice.
Comment 4 Carlos Garcia Campos 2012-04-19 23:48:13 PDT 
Committed r114720: <http://trac.webkit.org/changeset/114720>