Bug 84140 - Script make_names.pl should generate consistent .h & .cpp files
Summary: Script make_names.pl should generate consistent .h & .cpp files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 03:13 PDT by Vivek Galatage
Modified: 2012-04-17 10:12 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2012-04-17 04:19 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-04-17 03:13:09 PDT
Source/WebCore/dom/make_names.pl should generate the .h & .cpp file in consistent manner.

Currently while generating the HTMLNames.cpp (same is applicable to all such *Names.cpp files) when the line for the namespace URI is written, a newline is not added.

Hence the "// Tags" statement is put after the define for namespace URI.

Also the additional ';' after the DEFINE_GLOBALS is not required as this will be added by the macro expansion.
Comment 1 Vivek Galatage 2012-04-17 03:15:31 PDT
Done all the necessary fixes in the make_names.pl and uploading the patch now.
Comment 2 Vivek Galatage 2012-04-17 04:19:44 PDT
Created attachment 137512 [details]
Patch
Comment 3 WebKit Review Bot 2012-04-17 10:12:36 PDT
Comment on attachment 137512 [details]
Patch

Clearing flags on attachment: 137512

Committed r114391: <http://trac.webkit.org/changeset/114391>
Comment 4 WebKit Review Bot 2012-04-17 10:12:42 PDT
All reviewed patches have been landed.  Closing bug.