WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84140
Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140
Summary
Script make_names.pl should generate consistent .h & .cpp files
Vivek Galatage
Reported
2012-04-17 03:13:09 PDT
Source/WebCore/dom/make_names.pl should generate the .h & .cpp file in consistent manner. Currently while generating the HTMLNames.cpp (same is applicable to all such *Names.cpp files) when the line for the namespace URI is written, a newline is not added. Hence the "// Tags" statement is put after the define for namespace URI. Also the additional ';' after the DEFINE_GLOBALS is not required as this will be added by the macro expansion.
Attachments
Patch
(2.29 KB, patch)
2012-04-17 04:19 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vivek Galatage
Comment 1
2012-04-17 03:15:31 PDT
Done all the necessary fixes in the make_names.pl and uploading the patch now.
Vivek Galatage
Comment 2
2012-04-17 04:19:44 PDT
Created
attachment 137512
[details]
Patch
WebKit Review Bot
Comment 3
2012-04-17 10:12:36 PDT
Comment on
attachment 137512
[details]
Patch Clearing flags on attachment: 137512 Committed
r114391
: <
http://trac.webkit.org/changeset/114391
>
WebKit Review Bot
Comment 4
2012-04-17 10:12:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug