Bug 84136 - [EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled
Summary: [EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 02:24 PDT by Michal Pakula vel Rutka
Modified: 2012-04-23 08:06 PDT (History)
4 users (show)

See Also:


Attachments
adds const to EFL PlatformMenuDescription (1.42 KB, patch)
2012-04-17 04:09 PDT, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2012-04-17 02:24:43 PDT
In EFL WebKit2 when ENABLE_CONTEXT_MENUS is set true and CROSS_PLATFORM_CONTEXT_MENUS are set false, there is a build break caused by mismatch between contextMenuItemVector declaration which uses PlatformMenuDescription (defined as Vector<ContexMenuItem and definition which uses const Vector<ContextMenuItem>*. This fixed the build break by adding const to EFL PlatformMenuDesciption.
Comment 1 Michal Pakula vel Rutka 2012-04-17 03:46:23 PDT
EFL WebKit2 has CONTEXT_MENUS disabled so this patch currently does not blocks the build.
Comment 2 Michal Pakula vel Rutka 2012-04-17 04:09:48 PDT
Created attachment 137510 [details]
adds const to EFL PlatformMenuDescription
Comment 3 Grzegorz Czajkowski 2012-04-17 05:25:05 PDT
LGTM.
Comment 4 WebKit Review Bot 2012-04-23 08:05:59 PDT
Comment on attachment 137510 [details]
adds const to EFL PlatformMenuDescription

Clearing flags on attachment: 137510

Committed r114902: <http://trac.webkit.org/changeset/114902>
Comment 5 WebKit Review Bot 2012-04-23 08:06:04 PDT
All reviewed patches have been landed.  Closing bug.