Bug 84134 - [BlackBerry] Export globalInitialize()
Summary: [BlackBerry] Export globalInitialize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 02:10 PDT by George Staikos
Modified: 2012-04-17 02:48 PDT (History)
2 users (show)

See Also:


Attachments
patch to fix it (1.08 KB, patch)
2012-04-17 02:10 PDT, George Staikos
no flags Details | Formatted Diff | Diff
patch to fix it (1.14 KB, patch)
2012-04-17 02:20 PDT, George Staikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-04-17 02:10:12 PDT
Created attachment 137492 [details]
patch to fix it

globalInitialize() should have been exported and was not.  Do it.
Comment 1 WebKit Review Bot 2012-04-17 02:12:22 PDT
Attachment 137492 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BlackBerryGlo..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 George Staikos 2012-04-17 02:20:03 PDT
Created attachment 137498 [details]
patch to fix it
Comment 3 Nikolas Zimmermann 2012-04-17 02:37:19 PDT
Comment on attachment 137498 [details]
patch to fix it

r=me!
Comment 4 WebKit Review Bot 2012-04-17 02:48:31 PDT
Comment on attachment 137498 [details]
patch to fix it

Clearing flags on attachment: 137498

Committed r114361: <http://trac.webkit.org/changeset/114361>
Comment 5 WebKit Review Bot 2012-04-17 02:48:35 PDT
All reviewed patches have been landed.  Closing bug.