Bug 84101 - HTML5 Video Full Screen button broken (looks like white square)
Summary: HTML5 Video Full Screen button broken (looks like white square)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-16 17:08 PDT by Jer Noble
Modified: 2012-04-17 12:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (366.26 KB, patch)
2012-04-16 17:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-04-16 17:08:31 PDT
HTML5 Video Full Screen button broken (looks like white square)
Comment 1 Jer Noble 2012-04-16 17:09:06 PDT
<rdar://problem/11260404>
Comment 2 Jer Noble 2012-04-16 17:11:35 PDT
Created attachment 137436 [details]
Patch
Comment 3 mitz 2012-04-16 17:52:32 PDT
Comment on attachment 137436 [details]
Patch

What about the exit full screen button? Does this fix it too?
Comment 4 Jer Noble 2012-04-16 17:58:24 PDT
(In reply to comment #3)
> (From update of attachment 137436 [details])
> What about the exit full screen button? Does this fix it too?

It does.  Once the correct -webkit-appearance is set, rendering the correct state is taken care of by MediaControlElements.cpp.

Thanks!
Comment 5 WebKit Review Bot 2012-04-17 12:44:30 PDT
Comment on attachment 137436 [details]
Patch

Clearing flags on attachment: 137436

Committed r114417: <http://trac.webkit.org/changeset/114417>
Comment 6 WebKit Review Bot 2012-04-17 12:44:35 PDT
All reviewed patches have been landed.  Closing bug.