WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84068
Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068
Summary
Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
Ryosuke Niwa
Reported
2012-04-16 13:27:31 PDT
Chromium Win Perf fails to create WebKitBuild directory because mkdir on Windows doesn't support -p option. Since the download step automatically creates WebKitBuild directory now, this step is completely redundant.
Attachments
Fixes the failure
(2.52 KB, patch)
2012-04-16 13:40 PDT
,
Ryosuke Niwa
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-04-16 13:40:36 PDT
Created
attachment 137394
[details]
Fixes the failure
Eric Seidel (no email)
Comment 2
2012-04-16 13:50:51 PDT
Comment on
attachment 137394
[details]
Fixes the failure I assume this step was only used by the perf bot.
Eric Seidel (no email)
Comment 3
2012-04-16 13:51:12 PDT
You are aware we have unit tests for master.cfg, rght?
Ryosuke Niwa
Comment 4
2012-04-16 13:59:52 PDT
(In reply to
comment #2
)
> (From update of
attachment 137394
[details]
) > I assume this step was only used by the perf bot.
It's also used by testers but it's redundant there as well since download-built-product makes WebKitBuild directory as I explained in the change log. (In reply to
comment #3
)
> You are aware we have unit tests for master.cfg, rght?
Oh, I didn't know that. Did someone add it recently? I don't think a unit test is helpful for this file though.
Eric Seidel (no email)
Comment 5
2012-04-16 14:03:40 PDT
I added it long ago. :) It's of some use. it doesn't cover everything by far.
Ryosuke Niwa
Comment 6
2012-04-16 14:14:10 PDT
(In reply to
comment #5
)
> I added it long ago. :) It's of some use. it doesn't cover everything by far.
I guess we can test whether config.json loads, etc... but we can't really test whether the code change we made is correct or not by unit tests there because most of master.cfg just calls out to other scripts.
Ryosuke Niwa
Comment 7
2012-04-17 00:18:49 PDT
Committed
r114353
: <
http://trac.webkit.org/changeset/114353
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug