Bug 84058 – Move AudioDestinationChromium FIFO class to its own class.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raymond Toy]

Move AudioDestinationChromium FIFO class to its own class.

[Raymond Toy]

Created attachment 137372 [details]
Patch

[Chris Rogers]

Comment on attachment 137372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137372&action=review

> Source/WebCore/WebCore.gypi:3177
> +            'platform/audio/AudioPullFIFO.h',

nit: alpha order

> Source/WebCore/platform/audio/AudioPullFIFO.h:38
> +// fulfill a request.

It's probably a good idea to update this comment to be a little more general.  I think the first part:

"A FIFO (First In First Out) buffer to handle mismatches in"

and the last part:
"This FIFO will ask the provider for more data when necessary to fulfill a request."

Are good, but the middle part can be made more general -- and also maybe add the concept of "pull" in there (as opposed to push)

> Source/WebKit/chromium/src/AudioDestinationChromium.h:34
> +#include "AudioPullFIFO.h"

Can you forward declare this class in the header file, and move this #include to the .cpp?

[Raymond Toy]

Created attachment 137396 [details]
Patch

[Raymond Toy]

Comment on attachment 137372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137372&action=review

>> Source/WebCore/WebCore.gypi:3177
>> +            'platform/audio/AudioPullFIFO.h',
> 
> nit: alpha order

Fixed.

>> Source/WebCore/platform/audio/AudioPullFIFO.h:38
>> +// fulfill a request.
> 
> It's probably a good idea to update this comment to be a little more general.  I think the first part:
> 
> "A FIFO (First In First Out) buffer to handle mismatches in"
> 
> and the last part:
> "This FIFO will ask the provider for more data when necessary to fulfill a request."
> 
> Are good, but the middle part can be made more general -- and also maybe add the concept of "pull" in there (as opposed to push)

Updated.

>> Source/WebKit/chromium/src/AudioDestinationChromium.h:34
>> +#include "AudioPullFIFO.h"
> 
> Can you forward declare this class in the header file, and move this #include to the .cpp?

Done.

[Raymond Toy]

Created attachment 137554 [details]
Patch

[Chris Rogers]

Comment on attachment 137554 [details]
Patch

Thanks Ray!

[WebKit Review Bot]

Comment on attachment 137554 [details]
Patch

Clearing flags on attachment: 137554

Committed r114970: <http://trac.webkit.org/changeset/114970>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.