WebMediaPlayer.h has several style violations that need fixing:
- enum values should be prefixed with the enum name. (Preload::None -> Preload::PreloadNone)
- WebTimeRange & WebTimeRanges should be in WebTimeRange.h .
Created attachment 137412 [details]
Please wait for approval from email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org or email@example.com before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
This changes the exposed API, so is there a corresponding chromium patch to update to the new names/etc?
(In reply to comment #4)
> This changes the exposed API, so is there a corresponding chromium patch to update to the new names/etc?
There will be. I haven't created it yet. I was planning on landing this, WebKit DEPS roll, landing chromium changes to use new enum name, WebKit chromium deps roll. Remove old names.
When this rolls into the chromium tree, will the chromium code using this still compile?
(In reply to comment #6)
> When this rolls into the chromium tree, will the chromium code using this still compile?
Yes. I'm building this patch w/ ToT chrome right now. That is why I still have the old enum values in there. The plan is to land this, update chrome to the new enum value names, and then remove to old names in webkit.
Ah gotcha, I missed that you were leaving the old values in as aliases. Proceed!
(In reply to comment #8)
> Ah gotcha, I missed that you were leaving the old values in as aliases. Proceed!
No problem. Could you please cq+ my patch.
Comment on attachment 137412 [details]
Clearing flags on attachment: 137412
Committed r114329: <http://trac.webkit.org/changeset/114329>
All reviewed patches have been landed. Closing bug.