Bug 84044 – [GTK] Expose image links properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Mario Sanchez Prada]

This should allow unskipping accessibility/image-link.html

[Mario Sanchez Prada]

Created attachment 214963 [details]
Patch proposal

Turns out that all we needed to do was to properly expose the URL in DRT/WKTR, as both link and image sources are being exposed already through the AtkHyperlinkImpl/AtkHyperlink combo.

Also, turns out that image-link.html was actually not being declared as "failure", but was providing the wrong expectations.

All that is addressed in the current patch

[chris fleizach]

Comment on attachment 214963 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=214963&action=review

does this have any affect outside of the testing infrastructure? it seems that there's only layout test and DRT changes

> Tools/ChangeLog:9
> +        attribute for the AccessibilityUIElement wrapper. For coherence

the word "attribute" is duplicated

[Mario Sanchez Prada]

(In reply to comment #2)
> (From update of attachment 214963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214963&action=review
> 
> does this have any affect outside of the testing infrastructure? it seems that there's only layout test and DRT changes

No, it doesn't. At the beginning I thought it was a problem in the ATK side, but turned out that part is ok and we were missing only this bit to be able to properly test it.

Another thing is image-map1.html. We'll need some changes in the wrapper because we are not exposing properly the description for image map links when it's placed in the 'title' attribute. But that's another bug (bug 84045).

> > Tools/ChangeLog:9
> > +        attribute for the AccessibilityUIElement wrapper. For coherence
> 
> the word "attribute" is duplicated

Thanks, I'll change before landing

[Mario Sanchez Prada]

Committed r157859: <http://trac.webkit.org/changeset/157859>