Bug 84033 - [chromium] Enabled threaded animations in DRT
Summary: [chromium] Enabled threaded animations in DRT
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
URL:
Keywords:
Depends on: 86013 90000
Blocks: 83283 85813
  Show dependency tree / graph
 
Reported: 2012-04-16 06:52 PDT by vollick
Modified: 2013-04-09 17:05 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2012-05-28 08:16 PDT, vollick 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (589.18 KB, application/zip)
2012-05-28 18:42 PDT, WebKit Review Bot 		no flags Details
Patch (24.32 KB, patch)
2012-08-02 06:13 PDT, vollick 		abarth: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-04-16 06:52:23 PDT 
Turn on threaded animations in DumpRenderTree.
Comment 1 vollick 2012-05-28 08:16:38 PDT 
Created attachment 144367 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-28 18:42:45 PDT 
Comment on attachment 144367 [details]
Patch

Attachment 144367 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12841406

New failing tests:
animations/animation-iteration-event-destroy-renderer.html
compositing/reflections/nested-reflection-animated.html
Comment 3 WebKit Review Bot 2012-05-28 18:42:48 PDT 
Created attachment 144421 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Adrienne Walker 2012-07-18 15:01:27 PDT 
Comment on attachment 144367 [details]
Patch

Removing review flag until DRT tests are passing, if you still want this two month old patch landed.
Comment 5 vollick 2012-08-02 06:13:54 PDT 
Created attachment 156060 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-02 06:16:31 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 7 Adam Barth 2012-08-02 13:42:04 PDT 
Comment on attachment 156060 [details]
Patch

This patch is spinning in the cr-linux-ews.
Comment 8 Eric Seidel (no email) 2012-08-02 14:04:42 PDT 
That happens most often because your patch introduces flakiness.  If you click on the cr-linux bubble and examine the individual runs, you'll see flaky results.
Comment 9 Stephen Chenney 2013-04-09 17:05:56 PDT 
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.