Bug 84024 – [chromium] Layout Test editing/pasteboard/emacs-ctrl-k-with-move.html is failing (CRASH)

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Takashi Toyoshima]

The following layout test is failing on Chromium Mac10.5, 10.5 (dbg), 10.6, 10.6 (dbg), and 10.7.

editing/pasteboard/emacs-ctrl-k-with-move.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fpasteboard%2Femacs-ctrl-k-with-move.html

I'm not sure who is familiar to this crash. But I notice one of stack trace contains WebCore::executeYank and this test is for editing. I guess Niwa-san may be familiar to this.

[Takashi Toyoshima]

update expectations.
http://trac.webkit.org/changeset/114248

[Kent Tamura]

(In reply to comment #1)
> update expectations.
> http://trac.webkit.org/changeset/114248

You must not skip this test on Mac.  It tests a feature for Mac.  You need to resolve the failure.

[Kent Tamura]

Clearly http://trac.webkit.org/changeset/114220/ is the trigger.  Don't hesitate to roll it out.

[Jia Pu]

(In reply to comment #3)
> Clearly http://trac.webkit.org/changeset/114220/ is the trigger.  Don't hesitate to roll it out.

If this failure is caused a crash in Editor::insertTextWithoutSendingTextEvent, which seems to be the case to em, the patch in bug 84010 fixes it.

Can someone review it?

[Takashi Toyoshima]

Oops, I miss reverting.
Now it's difficult to revert related change 114220, 114231, and 114266.

Jia Pu,
Could you fix this crush or manually revert them?

[Jia Pu]

(In reply to comment #5)
> Oops, I miss reverting.
> Now it's difficult to revert related change 114220, 114231, and 114266.
> 
> Jia Pu,
> Could you fix this crush or manually revert them?

It seems http://trac.webkit.org/changeset/114311 has already fixed this. You can revert the test back to original now.

[Takashi Toyoshima]

Thanks Jia!

I revert my previous expectation update.
http://trac.webkit.org/changeset/114479