Bug 84024 - [chromium] Layout Test editing/pasteboard/emacs-ctrl-k-with-move.html is failing (CRASH)
Summary: [chromium] Layout Test editing/pasteboard/emacs-ctrl-k-with-move.html is fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Toyoshima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-16 05:23 PDT by Takashi Toyoshima
Modified: 2012-04-17 21:12 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2012-04-16 05:23:53 PDT
The following layout test is failing on Chromium Mac10.5, 10.5 (dbg), 10.6, 10.6 (dbg), and 10.7.

editing/pasteboard/emacs-ctrl-k-with-move.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fpasteboard%2Femacs-ctrl-k-with-move.html

I'm not sure who is familiar to this crash. But I notice one of stack trace contains WebCore::executeYank and this test is for editing. I guess Niwa-san may be familiar to this.
Comment 1 Takashi Toyoshima 2012-04-16 07:00:53 PDT
update expectations.
http://trac.webkit.org/changeset/114248
Comment 2 Kent Tamura 2012-04-16 17:41:58 PDT
(In reply to comment #1)
> update expectations.
> http://trac.webkit.org/changeset/114248

You must not skip this test on Mac.  It tests a feature for Mac.  You need to resolve the failure.
Comment 3 Kent Tamura 2012-04-16 17:44:43 PDT
Clearly http://trac.webkit.org/changeset/114220/ is the trigger.  Don't hesitate to roll it out.
Comment 4 Jia Pu 2012-04-16 17:51:28 PDT
(In reply to comment #3)
> Clearly http://trac.webkit.org/changeset/114220/ is the trigger.  Don't hesitate to roll it out.

If this failure is caused a crash in Editor::insertTextWithoutSendingTextEvent, which seems to be the case to em, the patch in bug 84010 fixes it.

Can someone review it?
Comment 5 Takashi Toyoshima 2012-04-17 00:44:55 PDT
Oops, I miss reverting.
Now it's difficult to revert related change 114220, 114231, and 114266.

Jia Pu,
Could you fix this crush or manually revert them?
Comment 6 Jia Pu 2012-04-17 10:26:19 PDT
(In reply to comment #5)
> Oops, I miss reverting.
> Now it's difficult to revert related change 114220, 114231, and 114266.
> 
> Jia Pu,
> Could you fix this crush or manually revert them?

It seems http://trac.webkit.org/changeset/114311 has already fixed this. You can revert the test back to original now.
Comment 7 Takashi Toyoshima 2012-04-17 21:12:50 PDT
Thanks Jia!

I revert my previous expectation update.
http://trac.webkit.org/changeset/114479