Bug 83990 – Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Created attachment 137224 [details]
Screenshot with firstDayOfWeek()==1 (Monday)

Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0

[Kent Tamura]

Created attachment 137226 [details]
Patch

[Kentaro Hara]

Comment on attachment 137226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137226&action=review

> Source/WebCore/ChangeLog:8
> +        We passed the "weekStartDay" proerty value as a

Nit: *property*

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:163
> +static void addProperty(const char* name, unsigned value, DocumentWriter& writer)

I've not yet confirmed the spec, but should this be unsigned or int? What should happen if we pass a negative value for weekStartDay?

[Kentaro Hara]

Comment on attachment 137226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137226&action=review

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:208
> +    addProperty("weekStartDay", firstDayOfWeek(), writer);

Nit: BTW, maybe we can rename firstDayOfWeek() to weekStartDay() in another patch.

[Kent Tamura]

Comment on attachment 137226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137226&action=review

>> Source/WebCore/ChangeLog:8
>> +        We passed the "weekStartDay" proerty value as a
> 
> Nit: *property*

will fix

>> Source/WebCore/html/shadow/CalendarPickerElement.cpp:163
>> +static void addProperty(const char* name, unsigned value, DocumentWriter& writer)
> 
> I've not yet confirmed the spec, but should this be unsigned or int? What should happen if we pass a negative value for weekStartDay?

This should be unsigned because WebCore::firstDayOfWeek() is unsigned. We need no signed numbers for now.

[Kent Tamura]

Committed r114210: <http://trac.webkit.org/changeset/114210>