Bug 83982 - Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
Summary: Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-14 11:24 PDT by ChangSeok Oh
Modified: 2012-04-16 10:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.62 KB, patch)
2012-04-14 11:43 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (7.62 KB, patch)
2012-04-14 11:48 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2012-04-14 11:24:37 PDT
There are some issues to build with GLES for WebGL. This bug is for fixing them.
1. GL_BGRA is not defined in OpenGL ES, so it causes build-break at GraphicsContext3D::readRenderingResults.
2. getExtensions() is used without including a proper header file.
3. m_attributes is not defined, it should be replaced with m_attrs.
4. Omitted '}' for namespace WebCore.
5. Function argument of GraphicsContext3D::resolveMultisamplingIfNecessary is mismatched with its declaration.
Comment 1 ChangSeok Oh 2012-04-14 11:43:58 PDT
Created attachment 137215 [details]
Patch
Comment 2 ChangSeok Oh 2012-04-14 11:48:01 PDT
Created attachment 137216 [details]
Patch
Comment 3 WebKit Review Bot 2012-04-16 10:06:31 PDT
Comment on attachment 137216 [details]
Patch

Clearing flags on attachment: 137216

Committed r114268: <http://trac.webkit.org/changeset/114268>
Comment 4 WebKit Review Bot 2012-04-16 10:06:36 PDT
All reviewed patches have been landed.  Closing bug.