Bug 83972 - [Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
Summary: [Chromium] Add TextureUploader which allows us to use persistent GC3D state f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks: 81004
  Show dependency treegraph
 
Reported: 2012-04-13 21:19 PDT by David Reveman
Modified: 2012-04-17 15:42 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.99 KB, patch)
2012-04-13 21:33 PDT, David Reveman
no flags Details | Formatted Diff | Diff
Patch (27.09 KB, patch)
2012-04-14 20:27 PDT, David Reveman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2012-04-13 21:19:21 PDT
This is an initial patch to start cleaning up how texture uploads are handled by CCTextureUpdater. It doesn't change the interaction with LayerTextureUpdater. It just creates a TextureUploader class that is similar to the current TextureCopier class and allows us to add persistent state to the upload machinery so that we can land: https://bugs.webkit.org/show_bug.cgi?id=81004

The plan is to follow up with patches that moves a lot of the upload logic from the LayerTextureUpdater and LayerTexureSubImage to this new TextureUploader class.
Comment 1 David Reveman 2012-04-13 21:33:22 PDT
Created attachment 137197 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-13 22:45:01 PDT
Comment on attachment 137197 [details]
Patch

Attachment 137197 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12405225
Comment 3 David Reveman 2012-04-14 20:27:58 PDT
Created attachment 137229 [details]
Patch
Comment 4 James Robinson 2012-04-16 12:42:55 PDT
Comment on attachment 137229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137229&action=review

> Source/WebCore/platform/graphics/chromium/TextureUploader.h:40
> +class AcceleratedTextureUploader : public TextureUploader {

What would a non-accelerated TextureUploader be, out of curiosity?
Comment 5 David Reveman 2012-04-16 14:03:57 PDT
(In reply to comment #4)
> (From update of attachment 137229 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137229&action=review
> 
> > Source/WebCore/platform/graphics/chromium/TextureUploader.h:40
> > +class AcceleratedTextureUploader : public TextureUploader {
> 
> What would a non-accelerated TextureUploader be, out of curiosity?

Heh, hard to say :) I think this will become SubImageTextureUploader as we move the LayerTexureSubImage logic into the uploader class.
Comment 6 WebKit Review Bot 2012-04-17 15:42:28 PDT
Comment on attachment 137229 [details]
Patch

Clearing flags on attachment: 137229

Committed r114450: <http://trac.webkit.org/changeset/114450>
Comment 7 WebKit Review Bot 2012-04-17 15:42:33 PDT
All reviewed patches have been landed.  Closing bug.