RESOLVED FIXED 83963
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it 
https://bugs.webkit.org/show_bug.cgi?id=83963
Summary [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClient...
James Robinson
Reported 2012-04-13 17:16:41 PDT
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
Attachments
Patch (30.75 KB, patch)
2012-04-13 17:33 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-04-13 17:33:59 PDT
Created attachment 137186 [details] Patch
WebKit Review Bot
Comment 2 2012-04-13 17:39:08 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 3 2012-04-13 17:41:31 PDT
Daniel or Ami - would one of you mind taking a careful read of the threading comments I added in WebVideoFrameProvider.h and making sure they are correct and sufficient for somebody to safely use the interface without needing to look too much at the implementation?
Daniel Sievers
Comment 4 2012-04-13 17:54:10 PDT
(In reply to comment #3) > Daniel or Ami - would one of you mind taking a careful read of the threading comments I added in WebVideoFrameProvider.h and making sure they are correct and sufficient for somebody to safely use the interface without needing to look too much at the implementation? The comments sound good to me.
Adrienne Walker
Comment 5 2012-04-16 19:39:17 PDT
Comment on attachment 137186 [details] Patch R=me. Go, go, gtfo.
James Robinson
Comment 6 2012-04-16 20:04:22 PDT
Committed r114335: <http://trac.webkit.org/changeset/114335>
Note You need to log in before you can comment on or make changes to this bug.