Bug 83963 - [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
Summary: [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClient...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 17:16 PDT by James Robinson
Modified: 2012-04-16 20:04 PDT (History)
12 users (show)

See Also:


Attachments
Patch (30.75 KB, patch)
2012-04-13 17:33 PDT, James Robinson
enne: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-13 17:16:41 PDT
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
Comment 1 James Robinson 2012-04-13 17:33:59 PDT
Created attachment 137186 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-13 17:39:08 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-04-13 17:41:31 PDT
Daniel or Ami - would one of you mind taking a careful read of the threading comments I added in WebVideoFrameProvider.h and making sure they are correct and sufficient for somebody to safely use the interface without needing to look too much at the implementation?
Comment 4 Daniel Sievers 2012-04-13 17:54:10 PDT
(In reply to comment #3)
> Daniel or Ami - would one of you mind taking a careful read of the threading comments I added in WebVideoFrameProvider.h and making sure they are correct and sufficient for somebody to safely use the interface without needing to look too much at the implementation?

The comments sound good to me.
Comment 5 Adrienne Walker 2012-04-16 19:39:17 PDT
Comment on attachment 137186 [details]
Patch

R=me.  Go, go, gtfo.
Comment 6 James Robinson 2012-04-16 20:04:22 PDT
Committed r114335: <http://trac.webkit.org/changeset/114335>