Some more testing shows: -After r114071, the specialization/inline of r114072 gives little performance improvement -The biggest gain is actually because we avoid a memory allocation. This should be generalized in WTF I should move the improvement of r114072 over to WTF. + Do not go over the string when searching for a UChar > 0xff in a string of LChar
Created attachment 137182 [details] Patch
This introduce a tiny regression (< 1%) for replaceUsingStringSearch() with 1 character string but we do not regress to levels prior to r114072. On the plus side, this improves stringProtoFuncIndexOf() in similar ways to what was done for replaceUsingStringSearch(). I have an idea for another improvement for replaceUsingStringSearch(). If needed, I'll make a generalized inline version for replaceUsingStringSearch() and stringProtoFuncIndexOf().
Comment on attachment 137182 [details] Patch This seems reasonable. Could you add performance/testing information to your ChangeLog? That would make this an easy r+.
Comment on attachment 137182 [details] Patch I guess you have some perf information in the comments of the bug. They would be much better in the ChangeLog.
Committed r115132: <http://trac.webkit.org/changeset/115132>