Bug 83929 – Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart in preparation for turning on subpixel support.

[Emil A Eklund]

Created attachment 137124 [details]
Patch

[Julien Chaffraix]

Comment on attachment 137124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137124&action=review

> Source/WebCore/ChangeLog:22
> +        * rendering/RenderWidget.cpp:
> +        (WebCore::RenderWidget::updateWidgetGeometry):

Mhhh, left-over from another change? (RenderWidget is not marked in the bug description and should if you are also planning to change it)

> Source/WebCore/rendering/RenderWidget.cpp:183
> -    LayoutRect contentBox = contentBoxRect();
> +    IntRect contentBox = pixelSnappedIntRect(contentBoxRect());
>      if (!m_widget->transformsAffectFrameRect())
>          return setWidgetGeometry(absoluteContentBox());
>  
> -    LayoutRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
> +    IntRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());

I think this is only a partial change: RenderWidget::setWidgetGeometry still takes a LayoutRect and it shouldn't now that you are always passing an IntRect.

[Emil A Eklund]

Created attachment 137223 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 137223 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 137223 [details]
Patch

Clearing flags on attachment: 137223

Committed r114211: <http://trac.webkit.org/changeset/114211>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.