Bug 83923 – Track rem unit usage in StyleSheetInternal

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to the stylesheet instead so parser does not need to know about the document. This also avoids setting the flag unnecessarily when the stylesheet is not used.

[Antti Koivisto]

Created attachment 137116 [details]
patch

[Andreas Kling]

Comment on attachment 137116 [details]
patch

r=me

[Antti Koivisto]

Comment on attachment 137116 [details]
patch

This needs to deal with inline style too

[Andreas Kling]

(In reply to comment #3)
> (From update of attachment 137116 [details])
> This needs to deal with inline style too

Eep. Indeed. The easy way would be to simply have Document check the uses-rem-unit bit on its elementSheet() as well, but that would take us one step further away from killing elementSheet().

[WebKit Review Bot]

Comment on attachment 137116 [details]
patch

Attachment 137116 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12393979

New failing tests:
fast/css/rem-dynamic-scaling.html

[WebKit Review Bot]

Created attachment 137137 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Antti Koivisto]

http://trac.webkit.org/changeset/114168 (with a fix for the failing test)