WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83919
GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919
Summary
GC activity timer should be tied to allocation, not collection
Mark Hahnenberg
Reported
2012-04-13 11:10:50 PDT
Currently we schedule our GCActivityCallback timer at the end of a collection. This is not an accurate picture of small amounts of allocation, which is the timer's purpose in the first place. This can cause some extra unnecessary full GCs as well as wasting some memory if we haven't done a collection recently. We should move the scheduling to the allocation slow path, which would mostly mitigate these issues.
Attachments
Patch
(12.25 KB, patch)
2012-04-17 14:34 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2012-04-17 14:34:33 PDT
Created
attachment 137606
[details]
Patch
Geoffrey Garen
Comment 2
2012-04-17 17:38:16 PDT
Comment on
attachment 137606
[details]
Patch r=me
WebKit Review Bot
Comment 3
2012-04-18 09:18:50 PDT
Comment on
attachment 137606
[details]
Patch Clearing flags on attachment: 137606 Committed
r114511
: <
http://trac.webkit.org/changeset/114511
>
WebKit Review Bot
Comment 4
2012-04-18 09:18:54 PDT
All reviewed patches have been landed. Closing bug.
Mark Hahnenberg
Comment 5
2012-04-18 11:16:08 PDT
<
rdar://problem/11130716
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug