Bug 83919 - GC activity timer should be tied to allocation, not collection
: GC activity timer should be tied to allocation, not collection
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-13 11:10 PST by
Modified: 2012-04-18 11:16 PST (History)


Attachments
Patch (12.25 KB, patch)
2012-04-17 14:34 PST, Mark Hahnenberg
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-13 11:10:50 PST
Currently we schedule our GCActivityCallback timer at the end of a collection. This is not an accurate picture of small amounts of allocation, which is the timer's purpose in the first place. This can cause some extra unnecessary full GCs as well as wasting some memory if we haven't done a collection recently. We should move the scheduling to the allocation slow path, which would mostly mitigate these issues.
------- Comment #1 From 2012-04-17 14:34:33 PST -------
Created an attachment (id=137606) [details]
Patch
------- Comment #2 From 2012-04-17 17:38:16 PST -------
(From update of attachment 137606 [details])
r=me
------- Comment #3 From 2012-04-18 09:18:50 PST -------
(From update of attachment 137606 [details])
Clearing flags on attachment: 137606

Committed r114511: <http://trac.webkit.org/changeset/114511>
------- Comment #4 From 2012-04-18 09:18:54 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #5 From 2012-04-18 11:16:08 PST -------
<rdar://problem/11130716>