Bug 83907 - webkit fails IETC grid-column-002
Summary: webkit fails IETC grid-column-002
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL: http://samples.msdn.microsoft.com/iet...
Keywords:
Depends on:
Blocks: 76198 113729
  Show dependency tree / graph
 
Reported: 2012-04-13 10:51 PDT by Dave Tharp
Modified: 2013-04-02 10:24 PDT (History)
11 users (show)

See Also:

Attachments
Proposed trivial change: Don't accept '0' as a valid grid position and fix the test to enable CSS Grid Layout under testRunner. (13.78 KB, patch)
2013-04-01 17:17 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Tharp 2012-04-13 10:51:46 PDT 
Red is visible on the page.
Comment 1 Dave Tharp 2012-04-13 11:04:23 PDT 
Test has been imported in LayoutTests/ietestcenter/css3/grid
Comment 2 Julien Chaffraix 2013-04-01 16:05:21 PDT 
This test is invalid per the latest specification as a negative <integer> for grid-{column|row} has a definite meaning.
Comment 3 Julien Chaffraix 2013-04-01 16:21:06 PDT 
Sorry, this was posted to the wrong bug. '0' is still invalid for grid-{column|row} and is a bug in our implementation.
Comment 4 Julien Chaffraix 2013-04-01 17:17:45 PDT 
Created attachment 196044 [details]
Proposed trivial change: Don't accept '0' as a valid grid position and fix the test to enable CSS Grid Layout under testRunner.
Comment 5 WebKit Review Bot 2013-04-02 07:39:48 PDT 
Comment on attachment 196044 [details]
Proposed trivial change: Don't accept '0' as a valid grid position and fix the test to enable CSS Grid Layout under testRunner.

Clearing flags on attachment: 196044

Committed r147430: <http://trac.webkit.org/changeset/147430>
Comment 6 WebKit Review Bot 2013-04-02 07:39:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Julien Chaffraix 2013-04-02 10:24:20 PDT 
Removed the test from mac too in http://trac.webkit.org/changeset/147445.

This was forgotten in the original change and the Mac buildbots were listing the test as passing.