Bug 83903 - [BlackBerry] Increase padding for text element
Summary: [BlackBerry] Increase padding for text element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 10:43 PDT by Yongxin Dai
Modified: 2012-04-16 11:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2012-04-13 11:23 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2012-04-13 14:35 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2012-04-13 15:04 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2012-04-16 09:53 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2012-04-16 10:28 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2012-04-13 10:43:33 PDT 
For in-region scroll mode, the selection handle can completely be invisible before scroll is triggered when the user is dragging handle over bottom / top of visible area.
Comment 1 Yongxin Dai 2012-04-13 11:23:42 PDT 
Created attachment 137110 [details]
Patch
Comment 2 Antonio Gomes 2012-04-13 11:52:59 PDT 
Comment on attachment 137110 [details]
Patch

can not we get even a manual test?
Comment 3 Yongxin Dai 2012-04-13 12:03:58 PDT 
(In reply to comment #2)
> (From update of attachment 137110 [details])
> can not we get even a manual test?
It was tested manually with email application. Composite a email with enough lines to trigger scroll. Drag handle over the bottom and top, which verified that problem is fixed by the patch.
Comment 4 Antonio Gomes 2012-04-13 12:16:30 PDT 
I'm talking about this: webkit/ManualTests/blackberry/
Comment 5 Mike Fenton 2012-04-13 14:08:51 PDT 
ChangeLog needs to be updated to include details from the Git commit message.  Also should remove the duplicate author line.
Comment 6 Antonio Gomes 2012-04-13 14:17:56 PDT 
Comment on attachment 137110 [details]
Patch

please fix mike's comments.
Comment 7 Yongxin Dai 2012-04-13 14:20:11 PDT 
(In reply to comment #6)
> (From update of attachment 137110 [details])
> please fix mike's comments.
Sure.
Comment 8 Yongxin Dai 2012-04-13 14:35:13 PDT 
Created attachment 137153 [details]
Patch
Comment 9 Yongxin Dai 2012-04-13 15:04:21 PDT 
Created attachment 137159 [details]
Patch
Comment 10 Mike Fenton 2012-04-16 05:23:54 PDT 
Comment on attachment 137159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137159&action=review

Fix the typo and it looks good to me.

> Source/WebKit/blackberry/ChangeLog:6
> +        Reviewed nternally by Mike Fenton.

Typo move this below your comment as well since it's not an official webkit review.
Comment 11 Yongxin Dai 2012-04-16 09:53:04 PDT 
Created attachment 137357 [details]
Patch
Comment 12 Yongxin Dai 2012-04-16 10:28:23 PDT 
Created attachment 137362 [details]
Patch
Comment 13 WebKit Review Bot 2012-04-16 11:28:00 PDT 
Comment on attachment 137362 [details]
Patch

Clearing flags on attachment: 137362

Committed r114282: <http://trac.webkit.org/changeset/114282>
Comment 14 WebKit Review Bot 2012-04-16 11:28:05 PDT 
All reviewed patches have been landed.  Closing bug.