Bug 83899 - [chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
Summary: [chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 83316
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-13 10:01 PDT by Dana Jansens
Modified: 2012-04-13 20:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2012-04-13 10:09 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2012-04-13 17:54 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-04-13 10:01:19 PDT 
[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
Comment 1 Dana Jansens 2012-04-13 10:09:05 PDT 
Created attachment 137099 [details]
Patch
Comment 2 Dana Jansens 2012-04-13 10:10:03 PDT 
Comment on attachment 137099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137099&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:176
> +    if (m_layerRendererInitialized)

Nat you asked why about this in previous patch. Other uses of the texture manager are guarded by m_layerRendererInitialized, so I thought it should be consistent here.
Comment 3 Dana Jansens 2012-04-13 17:54:54 PDT 
Created attachment 137189 [details]
Patch

rebased
Comment 4 Adrienne Walker 2012-04-13 18:18:02 PDT 
Comment on attachment 137189 [details]
Patch

Looks good.  Thanks for splitting out this refactoring.
Comment 5 WebKit Review Bot 2012-04-13 20:32:59 PDT 
Comment on attachment 137189 [details]
Patch

Clearing flags on attachment: 137189

Committed r114202: <http://trac.webkit.org/changeset/114202>
Comment 6 WebKit Review Bot 2012-04-13 20:33:03 PDT 
All reviewed patches have been landed.  Closing bug.