Bug 83897 – [EFL][DRT] Enable Regions support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dominik Röttsches (drott)]

CSS Regions should be enabled in compilation to pass related tests.

[Dominik Röttsches (drott)]

For now, moving to test_expectations until implementation is marked complete in master bug.

[Dominik Röttsches (drott)]

Created attachment 165084 [details]
Patch

[Dominik Röttsches (drott)]

Gyuyoung, Ryuan, Chris - any objections to default enabling CSS Regions for EFL?

[Dominik Röttsches (drott)]

Will update the patch with pixel results.

[WebKit Review Bot]

Attachment 165084 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
LayoutTests/platform/efl/TestExpectations:169:  A test marked Skip or WontFix must not have other expectations.  [test/expectations] [5]
Total errors found: 1 in 129 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dominik Röttsches (drott)]

Created attachment 165090 [details]
Patch

[Dominik Röttsches (drott)]

Created attachment 165093 [details]
Patch v3, fixing style issue in TestExpectations.

[Gyuyoung Kim]

BTW, can't we adjust this into WK2 as well ?

[Gyuyoung Kim]

(In reply to comment #8)
> BTW, can't we adjust this into WK2 as well ?

I mean we need to verify whether this patch will not influence on EFL WK2 layout test before landing this. Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ?

[Dominik Röttsches (drott)]

(In reply to comment #9)
> (In reply to comment #8)
> > BTW, can't we adjust this into WK2 as well ?
> 
> I mean we need to verify whether this patch will not influence on EFL WK2 layout test before landing this. Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ?

The main TestExpectations file is searched by both bots, the results for the LayoutTests should be identical in this case, I checked this locally for the "regions" folder, but I'll double check again.

[Dominik Röttsches (drott)]

Created attachment 165390 [details]
Patch

[Dominik Röttsches (drott)]

(In reply to comment #9)
> Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ?

I had to put one test case on the wk2 TestExpectations file, see bug 97457. The rest works fine.

[WebKit Review Bot]

Comment on attachment 165390 [details]
Patch

Rejecting attachment 165390 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
tform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt
patching file LayoutTests/platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt
patching file LayoutTests/platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt
patching file LayoutTests/platform/efl/fast/regions/webkit-region-rule-expected.txt
patching file ChangeLog

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13989720

[Dominik Röttsches (drott)]

Created attachment 165409 [details]
Patch

[Dominik Röttsches (drott)]

Comment on attachment 165409 [details]
Patch

Trying again with rebased ChangeLog

[WebKit Review Bot]

Comment on attachment 165409 [details]
Patch

Clearing flags on attachment: 165409

Committed r129395: <http://trac.webkit.org/changeset/129395>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.