RESOLVED FIXED 83880
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry 
https://bugs.webkit.org/show_bug.cgi?id=83880
Summary [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhite...
Sudarsana Nagineni (babu)
Reported 2012-04-13 03:44:10 PDT
LayoutTestController needs implementation of addOriginAccessWhitelistEntry in order to unskip the following tests. http/tests/security/local-image-from-remote-whitelisted.html http/tests/xmlhttprequest/origin-whitelisting-all.html http/tests/xmlhttprequest/origin-whitelisting-exact-match.html http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
Attachments
Patch (3.92 KB, patch)
2012-04-19 04:01 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2012-04-19 08:43 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
patch (4.63 KB, patch)
2012-04-25 05:46 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (5.36 KB, patch)
2012-04-25 15:16 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-04-19 04:01:20 PDT
Created attachment 137874 [details] Patch Add addOriginAccessWhitelistEntry support.
Grzegorz Czajkowski
Comment 2 2012-04-19 05:19:01 PDT
LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-04-19 08:05:06 PDT
Comment on attachment 137874 [details] Patch How about implementing the removeOrigin counterpart in LTC as well?
Sudarsana Nagineni (babu)
Comment 4 2012-04-19 08:25:10 PDT
(In reply to comment #3) > (From update of attachment 137874 [details]) > How about implementing the removeOrigin counterpart in LTC as well? Make sense. Thanks! I will implement this one also and unskip relevant test.
Sudarsana Nagineni (babu)
Comment 5 2012-04-19 08:43:56 PDT
Created attachment 137906 [details] Patch Implemented addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-04-19 08:55:22 PDT
Comment on attachment 137906 [details] Patch Looks fine, thanks.
Sudarsana Nagineni (babu)
Comment 7 2012-04-25 05:46:01 PDT
Created attachment 138794 [details] patch rebased
WebKit Review Bot
Comment 8 2012-04-25 10:03:21 PDT
Comment on attachment 138794 [details] patch Clearing flags on attachment: 138794 Committed r115222: <http://trac.webkit.org/changeset/115222>
WebKit Review Bot
Comment 9 2012-04-25 10:03:26 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 10 2012-04-25 10:25:47 PDT
I think this patch introduced flakiness, probably because is not cleaning the whitelist on the test startup. Before -> 135 failures 3 new passes 5 flakes 1 missing results http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/631 After -> 136 failures 3 new passes 25 flakes 1 missing results http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/632
Sudarsana Nagineni (babu)
Comment 11 2012-04-25 15:11:33 PDT
Reopening to fix the newly introduced flakiness. Needs to reset the whitelist to default on the test startup.
Sudarsana Nagineni (babu)
Comment 12 2012-04-25 15:16:01 PDT
Created attachment 138880 [details] Patch fixed flakiness introduced by previous patch.
Thiago Marcos P. Santos
Comment 13 2012-04-25 15:22:23 PDT
(In reply to comment #12) > Created an attachment (id=138880) [details] > Patch > > fixed flakiness introduced by previous patch. LGTM. Tried on my machine, no regressions. Thanks.
WebKit Review Bot
Comment 14 2012-04-26 06:42:22 PDT
Comment on attachment 138880 [details] Patch Clearing flags on attachment: 138880 Committed r115307: <http://trac.webkit.org/changeset/115307>
WebKit Review Bot
Comment 15 2012-04-26 06:42:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.