LayoutTestController needs implementation of addOriginAccessWhitelistEntry in order to unskip the following tests. http/tests/security/local-image-from-remote-whitelisted.html http/tests/xmlhttprequest/origin-whitelisting-all.html http/tests/xmlhttprequest/origin-whitelisting-exact-match.html http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
Created attachment 137874 [details] Patch Add addOriginAccessWhitelistEntry support.
LGTM.
Comment on attachment 137874 [details] Patch How about implementing the removeOrigin counterpart in LTC as well?
(In reply to comment #3) > (From update of attachment 137874 [details]) > How about implementing the removeOrigin counterpart in LTC as well? Make sense. Thanks! I will implement this one also and unskip relevant test.
Created attachment 137906 [details] Patch Implemented addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
Comment on attachment 137906 [details] Patch Looks fine, thanks.
Created attachment 138794 [details] patch rebased
Comment on attachment 138794 [details] patch Clearing flags on attachment: 138794 Committed r115222: <http://trac.webkit.org/changeset/115222>
All reviewed patches have been landed. Closing bug.
I think this patch introduced flakiness, probably because is not cleaning the whitelist on the test startup. Before -> 135 failures 3 new passes 5 flakes 1 missing results http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/631 After -> 136 failures 3 new passes 25 flakes 1 missing results http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/632
Reopening to fix the newly introduced flakiness. Needs to reset the whitelist to default on the test startup.
Created attachment 138880 [details] Patch fixed flakiness introduced by previous patch.
(In reply to comment #12) > Created an attachment (id=138880) [details] > Patch > > fixed flakiness introduced by previous patch. LGTM. Tried on my machine, no regressions. Thanks.
Comment on attachment 138880 [details] Patch Clearing flags on attachment: 138880 Committed r115307: <http://trac.webkit.org/changeset/115307>