Bug 83870 - Web Inspector: timeline. Range selection works incorrect with right click
Summary: Web Inspector: timeline. Range selection works incorrect with right click
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 01:41 PDT by Ilya Tikhonovsky
Modified: 2012-04-16 10:25 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2012-04-13 15:00 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-04-13 01:41:03 PDT 
Scenario:
1) record some data
2) right click at some place (context menu appears)
3) left click in another place (context menu disappears and range selection mode enables)
4) move mouse
5) do left click 

a small range will be selected at last click position.
Range selection background left on the pane.
Comment 1 Andrey Kosyakov 2012-04-13 15:00:23 PDT 
Created attachment 137158 [details]
Patch
Comment 2 Pavel Feldman 2012-04-16 04:49:05 PDT 
Comment on attachment 137158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137158&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:473
> +        if (event.button !== 0)

We don't compare to 0.
Comment 3 Andrey Kosyakov 2012-04-16 10:25:53 PDT 
Committed r114272: <http://trac.webkit.org/changeset/114272>