Bug 83842 – Web Inspector: add inspector instrumentation interface for compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

This adds InspectorInstrumentation::{willComposite,didComposite}() and plumbs them down to the timeline models. The actual calls to these methods are platform-specific and appear in separate patches.

[Andrey Kosyakov]

Created attachment 137011 [details]
Patch

[WebKit Review Bot]

Comment on attachment 137011 [details]
Patch

Attachment 137011 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12393695

New failing tests:
inspector/timeline/timeline-enum-stability.html

[WebKit Review Bot]

Created attachment 137039 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Pavel Feldman]

Comment on attachment 137011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137011&action=review

> Source/WebCore/inspector/front-end/TimelineModel.js:53
> +    CompositeLayers: "CompositeLayers",

You need to update a test with it.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:-73
> -    recordStyles[recordTypes.BeginFrame] = { title: WebInspector.UIString("Frame Start"), category: categories["rendering"] };

Why did this move?

[Andrey Kosyakov]

Created attachment 137095 [details]
Patch

[Andrey Kosyakov]

(In reply to comment #4)
> 
> You need to update a test with it.

Fixed!

> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:-73
> > -    recordStyles[recordTypes.BeginFrame] = { title: WebInspector.UIString("Frame Start"), category: categories["rendering"] };
> 
> Why did this move?

For the consistency with other places (InspectorTimelineAgent, TimelindeModel) where we list all record types. Besides, since we group the records logically, we could as well try to match chronological order.

[Andrey Kosyakov]

Committed r118351: <http://trac.webkit.org/changeset/118351>