RESOLVED FIXED 83840
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context 
https://bugs.webkit.org/show_bug.cgi?id=83840
Summary [chromium] Consolidate adjustTextRenderMode copypasta into Skia context
Adrienne Walker
Reported 2012-04-12 18:12:00 PDT
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
Attachments
Patch (9.99 KB, patch)
2012-04-12 18:16 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-04-12 18:16:09 PDT
Created attachment 137009 [details] Patch
Dana Jansens
Comment 2 2012-04-12 21:20:35 PDT
Comment on attachment 137009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137009&action=review Nice work, this makes a lot of sense! > Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:663 > +void PlatformContextSkia::adjustTextRenderMode(SkPaint* paint) Can we make this an "SkPaint&" ?
Stephen White
Comment 3 2012-04-13 08:16:22 PDT
Comment on attachment 137009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137009&action=review >> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:663 >> +void PlatformContextSkia::adjustTextRenderMode(SkPaint* paint) > > Can we make this an "SkPaint&" ? Although WebKit coding style says use non-const refs for out parameters, it doesn't saying anything about inout params AFAICT. My personal preference is to use pointers, as Enne did here, since it makes it clearer at the call site that the parameter is being modified.
Dana Jansens
Comment 4 2012-04-13 09:02:23 PDT
Comment on attachment 137009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137009&action=review >>> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:663 >>> +void PlatformContextSkia::adjustTextRenderMode(SkPaint* paint) >> >> Can we make this an "SkPaint&" ? > > Although WebKit coding style says use non-const refs for out parameters, it doesn't saying anything about inout params AFAICT. My personal preference is to use pointers, as Enne did here, since it makes it clearer at the call site that the parameter is being modified. Oh ok! Good to know.
Adrienne Walker
Comment 5 2012-04-16 11:48:48 PDT
senorblanco, jamesr: ping for review?
WebKit Review Bot
Comment 7 2012-04-18 21:51:37 PDT
Comment on attachment 137009 [details] Patch Clearing flags on attachment: 137009 Committed r114607: <http://trac.webkit.org/changeset/114607>
WebKit Review Bot
Comment 8 2012-04-18 21:51:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.