RESOLVED FIXED 83838
Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838
Summary Prepare submitForm for seamless navigation
Adam Barth
Reported 2012-04-12 18:01:28 PDT
Prepare submitForm for seamless navigation
Attachments
Patch (1.94 KB, patch)
2012-04-12 18:04 PDT, Adam Barth
rniwa: review+
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01 (6.20 MB, application/zip)
2012-04-12 21:07 PDT, WebKit Review Bot
no flags
Archive of layout-test-results from ec2-cq-02 (6.39 MB, application/zip)
2012-04-12 23:04 PDT, WebKit Review Bot
no flags
Archive of layout-test-results from ec2-cq-01 (6.50 MB, application/zip)
2012-04-13 00:45 PDT, WebKit Review Bot
no flags
Adam Barth
Comment 1 2012-04-12 18:04:01 PDT
Ryosuke Niwa
Comment 2 2012-04-12 18:35:01 PDT
Comment on attachment 137006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137006&action=review > Source/WebCore/loader/FrameLoader.cpp:317 > + Frame* targetFrame = findFrameForNavigation(submission->target(), submission->state()->sourceDocument()); > if (!targetFrame) { > if (!DOMWindow::allowPopUp(m_frame) && !ScriptController::processingUserGesture()) > return; Can we flip the if-else below so that we can declare targetFrame inside the if?
Adam Barth
Comment 3 2012-04-12 18:39:33 PDT
(In reply to comment #2) > (From update of attachment 137006 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137006&action=review > > > Source/WebCore/loader/FrameLoader.cpp:317 > > + Frame* targetFrame = findFrameForNavigation(submission->target(), submission->state()->sourceDocument()); > > if (!targetFrame) { > > if (!DOMWindow::allowPopUp(m_frame) && !ScriptController::processingUserGesture()) > > return; > > Can we flip the if-else below so that we can declare targetFrame inside the if? Sure.
Adam Barth
Comment 4 2012-04-12 18:45:52 PDT
Actually, we can't because targetFrame is used by the rest of the function (i.e., on both branches) for targetFrame->navigationScheduler()->scheduleFormSubmission(submission);
Ryosuke Niwa
Comment 5 2012-04-12 18:47:54 PDT
(In reply to comment #4) > Actually, we can't because targetFrame is used by the rest of the function (i.e., on both branches) for targetFrame->navigationScheduler()->scheduleFormSubmission(submission); Okay.
WebKit Review Bot
Comment 6 2012-04-12 21:07:39 PDT
Comment on attachment 137006 [details] Patch Attachment 137006 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12396541 New failing tests: svg/text/font-size-below-point-five.svg
WebKit Review Bot
Comment 7 2012-04-12 21:07:45 PDT
Created attachment 137034 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
WebKit Review Bot
Comment 8 2012-04-12 23:04:47 PDT
Comment on attachment 137006 [details] Patch Rejecting attachment 137006 [details] from commit-queue. New failing tests: svg/transforms/text-with-mask-with-svg-transform.svg svg/text/font-size-below-point-five.svg Full output: http://queues.webkit.org/results/12391785
WebKit Review Bot
Comment 9 2012-04-12 23:04:53 PDT
Created attachment 137042 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
WebKit Review Bot
Comment 10 2012-04-13 00:45:31 PDT
Comment on attachment 137006 [details] Patch Rejecting attachment 137006 [details] from commit-queue. New failing tests: svg/text/font-size-below-point-five.svg Full output: http://queues.webkit.org/results/12392806
WebKit Review Bot
Comment 11 2012-04-13 00:45:37 PDT
Created attachment 137053 [details] Archive of layout-test-results from ec2-cq-01 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Adam Barth
Comment 12 2012-04-13 00:46:00 PDT
Ok. Maybe this is real. :)
Ryosuke Niwa
Comment 13 2012-04-13 00:48:22 PDT
(In reply to comment #12) > Ok. Maybe this is real. :) No.... it's failing about 50% of the time on the bots.
Adam Barth
Comment 14 2012-04-13 00:49:16 PDT
In that case, I'm just going to land this manually, but we should mark it as flaky so it doesn't annoy other folks.
Ryosuke Niwa
Comment 15 2012-04-13 00:51:09 PDT
(In reply to comment #14) > In that case, I'm just going to land this manually, but we should mark it as flaky so it doesn't annoy other folks. Also see http://code.google.com/p/chromium/issues/detail?id=74710.
Adam Barth
Comment 16 2012-04-13 00:53:53 PDT
Note You need to log in before you can comment on or make changes to this bug.