Bug 83837 - [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
: [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposit...
Product: WebKit
Classification: Unclassified
Component: WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Andrey Kosyakov
Depends on:
  Show dependency treegraph
Reported: 2012-04-12 17:51 PDT by Andrey Kosyakov
Modified: 2012-04-12 20:01 PDT (History)
5 users (show)

See Also:

Patch (3.25 KB, patch)
2012-04-12 17:56 PDT, Andrey Kosyakov
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-04-12 17:51:08 PDT
Both call sites of commitIfNeeded() used to call doComposite() immediately in case commitIfNeeded() returned true. Having these two merged into a single method will keep things slightly more compact and will simplify instrumentation of the code -- we'd like to report them together to the instrumentation layer.
Comment 1 Andrey Kosyakov 2012-04-12 17:56:13 PDT
Created attachment 137003 [details]
Comment 2 James Robinson 2012-04-12 17:59:45 PDT
Comment on attachment 137003 [details]

Ooh, that is nice. R=me
Comment 3 Andrey Kosyakov 2012-04-12 18:08:38 PDT
Committed r114063: <http://trac.webkit.org/changeset/114063>
Comment 4 Nat Duca 2012-04-12 20:01:33 PDT
Coolies. Nice one.