Bug 83837 - [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
: [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposit...
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-12 17:51 PST by
Modified: 2012-04-12 20:01 PST (History)


Attachments
Patch (3.25 KB, patch)
2012-04-12 17:56 PST, Andrey Kosyakov
jamesr: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-12 17:51:08 PST
Both call sites of commitIfNeeded() used to call doComposite() immediately in case commitIfNeeded() returned true. Having these two merged into a single method will keep things slightly more compact and will simplify instrumentation of the code -- we'd like to report them together to the instrumentation layer.
------- Comment #1 From 2012-04-12 17:56:13 PST -------
Created an attachment (id=137003) [details]
Patch
------- Comment #2 From 2012-04-12 17:59:45 PST -------
(From update of attachment 137003 [details])
Ooh, that is nice. R=me
------- Comment #3 From 2012-04-12 18:08:38 PST -------
Committed r114063: <http://trac.webkit.org/changeset/114063>
------- Comment #4 From 2012-04-12 20:01:33 PST -------
Coolies. Nice one.