Bug 83835 - window.open should prepare for seamless navigation by using findFrameForNavigation
Summary: window.open should prepare for seamless navigation by using findFrameForNavig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 17:27 PDT by Adam Barth
Modified: 2012-04-12 17:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2012-04-12 17:30 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-04-12 17:27:52 PDT 
window.open should prepare for seamless navigation by using findFrameForNavigation
Comment 1 Adam Barth 2012-04-12 17:30:48 PDT 
Created attachment 137000 [details]
Patch
Comment 2 Ryosuke Niwa 2012-04-12 17:37:48 PDT 
Comment on attachment 137000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137000&action=review

> Source/WebCore/loader/FrameLoader.cpp:2947
> +        // FIXME: Eventually all callers should supply the actual activeDocument
> +        // so we can call canNavigate with the right document.

OMG! This might be the culprit of the bug I've been haunting for ages.
Comment 3 Adam Barth 2012-04-12 17:42:41 PDT 
Comment on attachment 137000 [details]
Patch

Clearing flags on attachment: 137000

Committed r114057: <http://trac.webkit.org/changeset/114057>
Comment 4 Adam Barth 2012-04-12 17:42:45 PDT 
All reviewed patches have been landed.  Closing bug.