Bug 83830 - Integrate IETC CSS : grid layout tests
Summary: Integrate IETC CSS : grid layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Tharp
URL: http://samples.msdn.microsoft.com/iet...
Keywords:
Depends on:
Blocks: 81526
  Show dependency tree / graph
 
Reported: 2012-04-12 16:02 PDT by Dave Tharp
Modified: 2012-04-13 12:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (56.80 KB, patch)
2012-04-12 16:22 PDT, Dave Tharp 		no flags Details | Formatted Diff | Diff
Patch (57.59 KB, patch)
2012-04-13 09:24 PDT, Dave Tharp 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Tharp 2012-04-12 16:02:35 PDT 
Integrate the eleven css ietestcenter grid layout tests.  All eleven Fail, and bugs will be written against them.
Comment 1 Dave Tharp 2012-04-12 16:22:32 PDT 
Created attachment 136992 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-12 16:28:06 PDT 
Attachment 136992 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1
LayoutTests/platform/gtk/test_expectations.txt:1146:  More specific entry on line 1136 overrides line 1146 sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html  [test/expectations] [5]
LayoutTests/platform/gtk/test_expectations.txt:1147:  More specific entry on line 1135 overrides line 1147 sputnik/Unicode/Unicode_510/S7.6_A3.2.html  [test/expectations] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Tharp 2012-04-12 16:33:44 PDT 
(In reply to comment #2)

Note these failures were already in the file.  I didn't fix them because I didn't want to interfere with potential ongoing gardening I am not involved in.

> Attachment 136992 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1
> LayoutTests/platform/gtk/test_expectations.txt:1146:  More specific entry on line 1136 overrides line 1146 sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html  [test/expectations] [5]
> LayoutTests/platform/gtk/test_expectations.txt:1147:  More specific entry on line 1135 overrides line 1147 sputnik/Unicode/Unicode_510/S7.6_A3.2.html  [test/expectations] [5]
> Total errors found: 2 in 17 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Tharp 2012-04-13 09:24:36 PDT 
Created attachment 137093 [details]
Patch
Comment 5 Dave Tharp 2012-04-13 09:26:29 PDT 
(In reply to comment #4)
> Created an attachment (id=137093) [details]
> Patch

OK, so the style error caused by the (unrelated to my tests) duplicate FAIL entries for the sputnik unicode tests was bugging me. So I fixed it along with the rest of my patch.
Comment 6 Dave Tharp 2012-04-13 11:08:13 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=137093) [details] [details]
> > Patch
> 
> OK, so the style error caused by the (unrelated to my tests) duplicate FAIL entries for the sputnik unicode tests was bugging me. So I fixed it along with the rest of my patch.

Just saw that zandobersek fixed the duplicates.  I'll remove my fix when I land this.
Comment 7 Adam Barth 2012-04-13 11:14:47 PDT 
Comment on attachment 137093 [details]
Patch

rs=me
Comment 8 Tom Zakrajsek 2012-04-13 12:39:42 PDT 
Committed r114162: <http://trac.webkit.org/changeset/114162>