Bug 83830 – Integrate IETC CSS : grid layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Tharp]

Integrate the eleven css ietestcenter grid layout tests.  All eleven Fail, and bugs will be written against them.

[Dave Tharp]

Created attachment 136992 [details]
Patch

[WebKit Review Bot]

Attachment 136992 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1
LayoutTests/platform/gtk/test_expectations.txt:1146:  More specific entry on line 1136 overrides line 1146 sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html  [test/expectations] [5]
LayoutTests/platform/gtk/test_expectations.txt:1147:  More specific entry on line 1135 overrides line 1147 sputnik/Unicode/Unicode_510/S7.6_A3.2.html  [test/expectations] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Tharp]

(In reply to comment #2)

Note these failures were already in the file.  I didn't fix them because I didn't want to interfere with potential ongoing gardening I am not involved in.

> Attachment 136992 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1
> LayoutTests/platform/gtk/test_expectations.txt:1146:  More specific entry on line 1136 overrides line 1146 sputnik/Unicode/Unicode_510/S7.6_A5.3_T2.html  [test/expectations] [5]
> LayoutTests/platform/gtk/test_expectations.txt:1147:  More specific entry on line 1135 overrides line 1147 sputnik/Unicode/Unicode_510/S7.6_A3.2.html  [test/expectations] [5]
> Total errors found: 2 in 17 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Tharp]

Created attachment 137093 [details]
Patch

[Dave Tharp]

(In reply to comment #4)
> Created an attachment (id=137093) [details]
> Patch

OK, so the style error caused by the (unrelated to my tests) duplicate FAIL entries for the sputnik unicode tests was bugging me. So I fixed it along with the rest of my patch.

[Dave Tharp]

(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=137093) [details] [details]
> > Patch
> 
> OK, so the style error caused by the (unrelated to my tests) duplicate FAIL entries for the sputnik unicode tests was bugging me. So I fixed it along with the rest of my patch.

Just saw that zandobersek fixed the duplicates.  I'll remove my fix when I land this.

[Adam Barth]

Comment on attachment 137093 [details]
Patch

rs=me

[Tom Zakrajsek]

Committed r114162: <http://trac.webkit.org/changeset/114162>