RESOLVED FIXED Bug 83804
[Chromium] Avoid unnecessary full tile updates for checkerboard tiles. 
https://bugs.webkit.org/show_bug.cgi?id=83804
Summary [Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
David Reveman
Reported 2012-04-12 12:11:11 PDT
Partial updates can always be allowed when a tile is currently checkerboard but an old tile texture currently exist.
Attachments
Patch (2.73 KB, patch)
2012-04-12 18:02 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Patch (4.75 KB, patch)
2012-04-12 18:19 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (6.07 MB, application/zip)
2012-04-12 23:38 PDT, WebKit Review Bot 		no flags
Details
Patch (11.79 KB, patch)
2012-04-13 01:31 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Patch (30.73 KB, patch)
2012-04-13 15:00 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Patch (30.60 KB, patch)
2012-04-13 20:40 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-04-12 13:45:16 PDT
Are you thinking of storing something on the tile like 'isDirtyOnImpl' that says the tile has not been updated since becoming dirty?
David Reveman
Comment 2 2012-04-12 18:02:34 PDT
Created attachment 137005 [details] Patch
Dana Jansens
Comment 3 2012-04-12 18:05:08 PDT
Comment on attachment 137005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137005&action=review > Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:352 > + if (!tile->isInUseOnImpl) > + return false; > + Also in tileOnlyNeedsPartialUpdate() right?
David Reveman
Comment 4 2012-04-12 18:19:27 PDT
Created attachment 137012 [details] Patch
Dana Jansens
Comment 5 2012-04-12 18:21:05 PDT
Comment on attachment 137012 [details] Patch +1
WebKit Review Bot
Comment 6 2012-04-12 23:38:21 PDT
Comment on attachment 137012 [details] Patch Attachment 137012 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12396581 New failing tests: TiledLayerChromiumTest.partialUpdates
WebKit Review Bot
Comment 7 2012-04-12 23:38:27 PDT
Created attachment 137044 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
David Reveman
Comment 8 2012-04-13 01:31:30 PDT
Created attachment 137059 [details] Patch
James Robinson
Comment 9 2012-04-13 12:35:36 PDT
Comment on attachment 137059 [details] Patch R=me
David Reveman
Comment 10 2012-04-13 15:00:15 PDT
Created attachment 137157 [details] Patch Update unit test to verify new behavior
David Reveman
Comment 11 2012-04-13 20:40:20 PDT
Created attachment 137195 [details] Patch
Dana Jansens
Comment 12 2012-04-13 20:41:23 PDT
Comment on attachment 137195 [details] Patch You missed --no-review :)
WebKit Review Bot
Comment 13 2012-04-13 23:02:26 PDT
Comment on attachment 137195 [details] Patch Clearing flags on attachment: 137195 Committed r114203: <http://trac.webkit.org/changeset/114203>
WebKit Review Bot
Comment 14 2012-04-13 23:02:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.