Bug 83804 - [Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
Summary: [Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 12:11 PDT by David Reveman
Modified: 2012-04-13 23:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2012-04-12 18:02 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Patch (4.75 KB, patch)
2012-04-12 18:19 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (6.07 MB, application/zip)
2012-04-12 23:38 PDT, WebKit Review Bot 		no flags Details
Patch (11.79 KB, patch)
2012-04-13 01:31 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Patch (30.73 KB, patch)
2012-04-13 15:00 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Patch (30.60 KB, patch)
2012-04-13 20:40 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2012-04-12 12:11:11 PDT 
Partial updates can always be allowed when a tile is currently checkerboard but an old tile
texture currently exist.
Comment 1 Dana Jansens 2012-04-12 13:45:16 PDT 
Are you thinking of storing something on the tile like 'isDirtyOnImpl' that says the tile has not been updated since becoming dirty?
Comment 2 David Reveman 2012-04-12 18:02:34 PDT 
Created attachment 137005 [details]
Patch
Comment 3 Dana Jansens 2012-04-12 18:05:08 PDT 
Comment on attachment 137005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137005&action=review

> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:352
> +    if (!tile->isInUseOnImpl)
> +        return false;
> +

Also in tileOnlyNeedsPartialUpdate() right?
Comment 4 David Reveman 2012-04-12 18:19:27 PDT 
Created attachment 137012 [details]
Patch
Comment 5 Dana Jansens 2012-04-12 18:21:05 PDT 
Comment on attachment 137012 [details]
Patch

+1
Comment 6 WebKit Review Bot 2012-04-12 23:38:21 PDT 
Comment on attachment 137012 [details]
Patch

Attachment 137012 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12396581

New failing tests:
TiledLayerChromiumTest.partialUpdates
Comment 7 WebKit Review Bot 2012-04-12 23:38:27 PDT 
Created attachment 137044 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 David Reveman 2012-04-13 01:31:30 PDT 
Created attachment 137059 [details]
Patch
Comment 9 James Robinson 2012-04-13 12:35:36 PDT 
Comment on attachment 137059 [details]
Patch

R=me
Comment 10 David Reveman 2012-04-13 15:00:15 PDT 
Created attachment 137157 [details]
Patch

Update unit test to verify new behavior
Comment 11 David Reveman 2012-04-13 20:40:20 PDT 
Created attachment 137195 [details]
Patch
Comment 12 Dana Jansens 2012-04-13 20:41:23 PDT 
Comment on attachment 137195 [details]
Patch

You missed --no-review :)
Comment 13 WebKit Review Bot 2012-04-13 23:02:26 PDT 
Comment on attachment 137195 [details]
Patch

Clearing flags on attachment: 137195

Committed r114203: <http://trac.webkit.org/changeset/114203>
Comment 14 WebKit Review Bot 2012-04-13 23:02:39 PDT 
All reviewed patches have been landed.  Closing bug.